Review main Merged

27824[CLEANUP] Remove outdated $CLIENT[FORMSTYLE]

Benni Mack CR +2 V +2 Normal +37 −85 updated 02/25/14, 21:34

Commit message

The functionality for having to deal with
browsers that did not support style="width: XYpx"
is not needed anymore, as any browser supported
in the TYPO3 universe can deal with that (even IE6).

This patch cleans up all the areas that dealt with
that part. Also, one dummy function in
FormEngine.php has been removed completely,
another in DocumentTemplate.php has been
deprecated.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Issues 1

Files 13

Review log 8

  1. Georg Ringer voted on patch set 1 V +1 CR +1 02/25/14, 12:01

  2. Markus Klein commented on patch set 1 CR -1 02/25/14, 12:42

    some questions

    DocumentTemplate.php:658

    Why FALSE here?

    DocumentTemplate.php:659

    We can't remove this part, can we? I mean in case some netscape comes along...

    RecordList.php:319

    no need for the ()
  3. Benni Mack uploaded patch set 2 02/25/14, 12:53

  4. Markus Klein commented on patch set 2 V +1 CR +1 02/25/14, 13:06

    comments will be fixed by benni at merge

    TypoScriptTemplateInfoHook.php:90

    TRUE

    TypoScriptTemplateInformationModuleFunctionController.php:349

    TRUE
  5. Wouter Wolters voted on patch set 2 V +1 CR +1 02/25/14, 20:34

  6. Benni Mack uploaded patch set 3 02/25/14, 21:34

  7. Benni Mack commented on patch set 3 V +2 CR +2 02/25/14, 21:34

    added comments from markus, nothing else.
  8. Benni Mack merged patch set 4 02/25/14, 21:34