Review main Merged

27825[CLEANUP] Remove security_level option from Authentications

Benni Mack CR +2 V +2 Normal +10 −92 updated 02/27/14, 17:21

Commit message

The option security_level option was deprecated
since 4.7 and can now be removed.

Also do some cleanup in related code.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 9

Review log 7

  1. Dmitry Dulepov commented on patch set 1 V +2 CR +2 02/25/14, 08:51

    Works fine here.
  2. Benni Mack commented on patch set 1 02/25/14, 08:55

    Hey, cool. I removed all occurrences but don't know if it was done correctly. Just stumbled over these parts... Maybe Helmut could have another look... Also: do we need to document this (again) in NEWS.md?
  3. Helmut Hummel commented on patch set 1 V -1 02/27/14, 16:33

    Tests fail. Will push an update
  4. Helmut Hummel uploaded patch set 2 02/27/14, 17:07

  5. Helmut Hummel commented on patch set 2 V +2 CR +2 02/27/14, 17:09

    Merging with taking Dmitry's vote into account. I only adapted the tests, commit message and did some minor additional cleanup in related code.
  6. Helmut Hummel merged patch set 3 02/27/14, 17:09

  7. Mr. Jenkins commented on patch set 2 02/27/14, 17:21