Review main Merged

27833[CLEANUP] Remove hardcoded valign="top" in FormEngine

Benni Mack CR +2 V +2 Easy +14 −9 updated 07/26/14, 14:20

Commit message

There are several places in the TYPO3 Form Engine
where the styling information about tables (valign)
is hard-coded.

The patch removes that, styling is done via CSS.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Marcin Sągol +1
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Susi Moog +1

Issues 1

Files 3

Review log 14

  1. Oliver Klee voted on patch set 1 CR +1 02/25/14, 11:14

  2. Stefan Neufeind commented on patch set 1 03/15/14, 21:49

    Can we simply remove this? Or would you say we also need to add something to t3skin css for the cases where you removed the valign? If so, let's do that in the same patch.
  3. Felix Kopp commented on patch set 1 V +1 CR +1 03/23/14, 17:10

    --WIP-- Do not commit
  4. Pascal Dürsteler commented on patch set 1 03/24/14, 13:39

    Should be "CLEANUP", not "CLENAUP".
  5. Georg Ringer updated the commit message in patch set 1 03/25/14, 17:16

  6. Mr. Jenkins commented on patch set 2 03/25/14, 17:31

  7. Benni Mack uploaded patch set 3 07/25/14, 18:48

  8. Stefan Neufeind commented on patch set 3 CR +1 07/25/14, 18:55

    Checked by reading that also the last-child makes sense.
  9. Wouter Wolters voted on patch set 3 V +1 CR +1 07/25/14, 19:10

  10. Marcin Sągol voted on patch set 3 CR +1 07/26/14, 07:12

  11. Oliver Klee voted on patch set 3 CR +1 07/26/14, 09:57

  12. Susi Moog voted on patch set 3 CR +1 V +1 07/26/14, 14:08

  13. Wouter Wolters voted on patch set 3 V +2 CR +2 07/26/14, 14:20

  14. Wouter Wolters merged patch set 3 07/26/14, 14:20