Review main Merged

27834[BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser

Peter Niederlag CR +2 V +2 Easy +1 −1 updated 06/01/15, 12:31

Commit message

The workspace preview adds the GET parameter ADMCMD_noBeUser
when requesting the frame for live preview.

$GLOBALS[BE_USER] is unset in index_ts.php when seeing ADMCMD_noBeUser.

In TypoScriptFrontendController fePreview=2 must not be set when
ADMCMD_noBeUser parameter is present to prevent fatal errors on
calling methods on a non-existent $GLOBALS[BE_USER]

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Lorenz Ulrich +1
    • Markus Bucher +1
  • Verified V +2
    • Andreas Kienast +2
    • Lorenz Ulrich +1
    • Markus Bucher +1

Issues 1

Files 1

Review log 13

  1. Wouter Wolters updated the commit message in patch set 1 03/07/14, 18:31

  2. Wouter Wolters voted on patch set 2 CR +1 03/07/14, 18:31

  3. Mr. Jenkins commented on patch set 2 03/07/14, 18:50

  4. Lorenz Ulrich commented on patch set 2 CR +1 V +1 09/16/14, 13:20

    Works fine here.
  5. Lorenz Ulrich uploaded patch set 3 09/16/14, 13:26

  6. Lorenz Ulrich updated the commit message in patch set 4 09/24/14, 16:18

  7. Lorenz Ulrich commented on patch set 4 CR +1 V +1 09/24/14, 16:18

    Only edited commit message. Works fine here.
  8. Tymoteusz Motylewski commented on patch set 4 10/16/14, 19:33

    how can it be tested? I tried the steps from the https://forge.typo3.org/issues/30643#note-14 on the current master, but it worked for me without an issue
  9. Mathias Schreiber wrote 12/17/14, 20:37

    Topic set to Typoscript
  10. Markus Bucher voted on patch set 4 V +1 CR +1 06/01/15, 12:11

  11. Andreas Kienast voted on patch set 4 CR +2 V +2 06/01/15, 12:30

  12. Andreas Kienast merged patch set 4 06/01/15, 12:31

  13. Andreas Kienast commented on patch set 5 06/01/15, 12:31

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 222c84674e7e8979b3f28b5eeaae05fdcd91f4ac