Review main Abandoned

27839[BUGFIX] remove auto_increment for primary key change

Christian Zenker CR 0 V 0 Easy +1 −1 updated 03/14/15, 19:14

Commit message

when updating the current primary key field of a
table with a new auto_increment field, the migration
service returns invalid MySQL code.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Markus Klein voted on patch set 1 CR +1 02/25/14, 16:26

  2. Markus Klein commented on patch set 1 V -1 CR 0 02/25/14, 16:31

    I tested this with Install Tool standalone. modified the core's fe_groups table def. simply renamed uid to uid_new and the primary key in the ext_tables.sql file. It is now possible to add the field, but in the second step it is not possible to execute any of the these generated statements ALTER TABLE fe_groups CHANGE uid_new uid_new int(11) unsigned; Current value: int(11) unsigned default NULL ALTER TABLE fe_groups DROP PRIMARY KEY; ALTER TABLE fe_groups ADD PRIMARY KEY (uid_new);
  3. Mathias Schreiber wrote 12/17/14, 14:34

    Topic set to EXT: install
  4. Markus Klein abandoned the change 03/14/15, 19:14

    No progress here for more than a year.