Review main Merged

27846[BUGFIX] Install Tool fatal with Oracle database

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 09/05/18, 18:49

Commit message

Installing TYPO3 with an Oracle database (oci8) fails.
After selecting oci8 and passing the credentials,
the install wizard crashes with:

PHP Fatal error: Cannot use object of type
TYPO3\CMS\Core\Configuration\ConfigurationManager as array in
typo3/sysext/install/Classes/Controller/Action/Step/DatabaseConnect.php
on line 93

Obviously $config got mixed up with $configurationManager.
Fix this typo.

Review

  • Code review CR +2
    • Steffen Müller +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Steffen Müller +2
    • Markus Klein +1

Issues 1

Files 1

Review log 22

  1. Andreas Kienast updated the commit message in patch set 1 09/05/18, 18:49

    DatabaseConnect.php:94 Reply

    Done in Patch Set #6
  2. Andreas Kienast updated the commit message in patch set 2 09/05/18, 18:49

  3. Andreas Kienast updated the commit message in patch set 3 09/05/18, 18:49

  4. Andreas Kienast updated the commit message in patch set 4 09/05/18, 18:49

  5. Markus Klein commented on patch set 5 09/05/18, 18:49

    Hi Andreas. Please have a look at our commit message guidelines. http://wiki.typo3.org/CommitMessage_Format_%28Git%29

    DatabaseConnect.php:94

    remove the ? TRUE : FALSE stuff as well. The === operation already yields a bool
  6. Markus Klein commented on patch set 5 1 comment 09/05/18, 18:49

    good catch btw.
  7. Andreas Kienast commented on patch set 5 1 comment 09/05/18, 18:49

  8. Markus Klein updated the commit message in patch set 6 09/05/18, 18:49

  9. Helmut Hummel voted on patch set 7 V +1 CR +1 09/05/18, 18:49

  10. Helmut Hummel updated the commit message in patch set 7 09/05/18, 18:49

  11. Helmut Hummel commented on patch set 8 09/05/18, 18:49

    good catch indeed! Thanks.
  12. Steffen Müller voted on patch set 9 CR -1 1 comment 09/05/18, 18:49

  13. Steffen Müller voted on patch set 10 V +2 CR +2 09/05/18, 18:49

  14. Steffen Müller uploaded patch set 10 09/05/18, 18:49

  15. Steffen Müller voted on patch set 10 V +1 CR +1 09/05/18, 18:49

  16. Steffen Müller voted on patch set 10 V 0 09/05/18, 18:49

  17. Markus Klein commented on patch set 10 V +1 CR +1 09/05/18, 18:49

    Giving v+1 here as well, but I doubt that any of the ACs has an Oracle db at hand to test that. So I trust Andreas here and the code was plain wrong before too.
  18. Helmut Hummel voted on patch set 9 V +1 CR +1 09/05/18, 18:49

  19. Wouter Wolters voted on patch set 9 CR +1 09/05/18, 18:49

  20. Wouter Wolters commented on patch set 10 CR +1 09/05/18, 18:49

    I opt for merging this.
  21. Steffen Müller merged patch set 11 09/05/18, 18:49

  22. Andreas Kienast uploaded patch set 6 09/05/18, 18:49