27846[BUGFIX] Install Tool fatal with Oracle database
Commit message
Review
-
Code review CR +2
- Steffen Müller +2
- Markus Klein +1
- Wouter Wolters +1
-
Verified V +2
- Steffen Müller +2
- Markus Klein +1
Issues 1
Files 1
Review log 22
-
Andreas Kienast updated the commit message in patch set 1 09/05/18, 18:49
-
Andreas Kienast updated the commit message in patch set 2 09/05/18, 18:49
-
Andreas Kienast updated the commit message in patch set 3 09/05/18, 18:49
-
Andreas Kienast updated the commit message in patch set 4 09/05/18, 18:49
-
Markus Klein commented on patch set 5 09/05/18, 18:49
Hi Andreas. Please have a look at our commit message guidelines. http://wiki.typo3.org/CommitMessage_Format_%28Git%29DatabaseConnect.php:94remove the ? TRUE : FALSE stuff as well. The === operation already yields a bool -
Markus Klein commented on patch set 5 1 comment 09/05/18, 18:49
good catch btw. -
Andreas Kienast commented on patch set 5 1 comment 09/05/18, 18:49
-
Markus Klein updated the commit message in patch set 6 09/05/18, 18:49
-
Helmut Hummel voted on patch set 7 V +1 CR +1 09/05/18, 18:49
-
Helmut Hummel updated the commit message in patch set 7 09/05/18, 18:49
-
Helmut Hummel commented on patch set 8 09/05/18, 18:49
good catch indeed! Thanks. -
Steffen Müller voted on patch set 9 CR -1 1 comment 09/05/18, 18:49
-
Steffen Müller voted on patch set 10 V +2 CR +2 09/05/18, 18:49
-
Steffen Müller uploaded patch set 10 09/05/18, 18:49
-
Steffen Müller voted on patch set 10 V +1 CR +1 09/05/18, 18:49
-
Steffen Müller voted on patch set 10 V 0 09/05/18, 18:49
-
Markus Klein commented on patch set 10 V +1 CR +1 09/05/18, 18:49
Giving v+1 here as well, but I doubt that any of the ACs has an Oracle db at hand to test that. So I trust Andreas here and the code was plain wrong before too. -
Helmut Hummel voted on patch set 9 V +1 CR +1 09/05/18, 18:49
-
Wouter Wolters voted on patch set 9 CR +1 09/05/18, 18:49
-
Wouter Wolters commented on patch set 10 CR +1 09/05/18, 18:49
I opt for merging this. -
Steffen Müller merged patch set 11 09/05/18, 18:49
-
Andreas Kienast uploaded patch set 6 09/05/18, 18:49
DatabaseConnect.php:94Reply