Review main Merged

27850[BUGFIX] Don't modify variables in tree view

Jigal van Hemert CR +2 V +2 Easy +6 −7 updated 02/25/14, 22:06

Commit message

The lowlevel array browser tries to modify the array that
is displayed if it's an object.
Now that TYPO3_LOADED_EXT is a simulated array (an object
which implements array access) modifying the data leads to
a fatal error. Instead the iterated value is now modified.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 8

  1. Wouter Wolters commented on patch set 1 V +1 CR +1 02/25/14, 20:10

    Fixes it for me
  2. Markus Klein voted on patch set 1 CR +1 02/25/14, 20:12

  3. Markus Klein commented on patch set 1 CR -1 02/25/14, 20:31

    Will investigate why the second level does not work
  4. Markus Klein commented on patch set 1 V -1 02/25/14, 21:54

    Got the problem: The loop in the tree() function is foreach ($arr as $key => $value) { ... In the second recursion $arr is of type LoadedExtensionArrayElement, which does not implement \Iterator interface. Therefore PHP iterates over the properties of the class and these are $package $extensionFilesToCheckFor $extensionInformation This is the output we see in the BE, but prefixed with (null byte)*(null byte) This is a) wrong b) killing all links c) killing xdebug Hallelujah!
  5. Markus Klein uploaded patch set 2 02/25/14, 22:00

  6. Markus Klein voted on patch set 2 V +1 CR +1 02/25/14, 22:01

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 02/25/14, 22:06

  8. Wouter Wolters merged patch set 3 02/25/14, 22:06