Review TYPO3_6-1 Merged

27853[BUGFIX] URL-encoded title in link wizard

Markus Klein CR +2 V +2 Normal +48 −36 updated 02/28/14, 00:06

Commit message

The security fix introduced a bug that the title is encoded
every time the link wizard is opened, leading to multiple
encoded strings.

Solution is to not encode it centrally but encode it just
before using it in the JavaScript context.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Files 2

Review log 7

  1. Markus Klein uploaded patch set 2 02/25/14, 20:56

  2. Markus Klein commented on patch set 1 02/25/14, 21:01

    ElementBrowser.php:365

    too many ()

    ElementBrowser.php:908

    one ) too much

    ElementBrowser.php:1727

    one ) too much
  3. Markus Klein commented on patch set 2 CR -2 02/27/14, 14:06

    On hold, until possible problem is sorted out on master.
  4. Markus Klein uploaded patch set 3 02/28/14, 00:00

  5. Markus Klein voted on patch set 3 V +1 CR +1 02/28/14, 00:06

  6. Markus Klein voted on patch set 3 V +2 CR +2 02/28/14, 00:06

  7. Markus Klein merged patch set 4 02/28/14, 00:06