Review main Merged

27862[FEATURE] Viewpage language selector

Erik Frister CR +2 V +2 Normal +133 −15 updated 08/18/15, 06:36

Commit message

Adds a language selector to the viewpage module.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
    • Markus Klein +1

Issues 1

Files 5

Review log 33

Show 8 earlier messages
  1. Tomas Norre Mikkelsen voted on patch set 1 CR +1 02/26/14, 10:11

  2. Julian Kleinhans commented on patch set 1 CR -1 02/26/14, 10:19

    common.js:153

    Please move the open bracket after the for statement and not below
  3. Mr. Jenkins commented on patch set 1 CR -1 V -1 02/26/14, 10:20

  4. Erik Frister uploaded patch set 2 02/26/14, 11:00

  5. Mr. Jenkins commented on patch set 2 02/26/14, 11:13

  6. Johannes Feustel voted on patch set 2 V +1 CR +1 02/26/14, 11:18

  7. Stefan Rotsch commented on patch set 2 CR +1 02/26/14, 12:28

    ViewModuleController.php:198

    Maybe split these long lines for better readability?
  8. Julian Kleinhans voted on patch set 2 V +1 CR +1 02/26/14, 12:59

  1. Tomas Norre Mikkelsen voted on patch set 2 CR +1 02/26/14, 13:01

  2. Ernesto Baschny commented on patch set 2 CR -1 02/26/14, 14:15

    Another nice addition, thanks! It will be a great asset for post 6.2. Let's also not forget about this. The timing for 6.2 is bad, as we don't want to open new potential pitfalls or bind our scarce resources with too many new things. That's also why our scarce base of current active contributors have so many issues already to review and solve, that we don't want to add yet more complexity. Which is why we have a strict development phase and a feature freeze which expired already some months ago. So -1 for new additional features at this stage of 6.2 development. Thanks!
  3. Ernesto Baschny voted on patch set 2 CR -2 02/26/14, 14:15

  4. Erik Frister commented on patch set 2 02/26/14, 14:50

    Hi Ernesto. Thanks for your feedback. What would be the next steps for me to make sure this gets merged eventually? I cannot change the target version in the forge ticket.
  5. Ernesto Baschny commented on patch set 2 CR -1 09/19/14, 15:36

    Upload a new patchset and use the "Releases: master" line instead of "Releases: 6.2". Also make sure you are based on current master instead of the TYPO3 6.2 branch. Then resubmit using the same Change-Id and you are good to go. I changed my vote to "-1" so that a new patchset with this modifications will be again "up to vote". Thanks!
  6. Tymoteusz Motylewski updated the commit message in patch set 3 09/20/14, 08:43

  7. Stefan Rotsch voted on patch set 3 CR +1 09/22/14, 06:59

  8. Tomas Norre Mikkelsen voted on patch set 3 CR +1 09/22/14, 07:06

  9. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to EXT: viewpage
  10. Alexander Opitz commented on patch set 3 06/24/15, 15:10

    Hi Erik, can you please rebase your code to latest master?
  11. Julian Kleinhans voted on patch set 3 CR +1 07/29/15, 07:26

  12. Daniel Goerz uploaded patch set 4 08/17/15, 20:19

  13. Daniel Goerz commented on patch set 4 V +1 08/17/15, 20:22

    Rebased, Cleanup and ExtJS->Jquery. I really like this feature. Lets get it in.
  14. Daniel Goerz uploaded patch set 5 08/17/15, 21:01

  15. Daniel Goerz voted on patch set 5 CR +1 V +1 08/17/15, 21:02

  16. Markus Klein commented on patch set 5 08/17/15, 21:16

    Main.js:108

    can't we put the event directly on the element?
  17. Markus Klein uploaded patch set 6 08/17/15, 22:00

  18. Markus Klein commented on patch set 6 V +1 CR +1 08/17/15, 22:00

    Found some more issues and fixed them.
  19. Stefan Neufeind voted on patch set 6 CR +1 08/17/15, 22:15

  20. Stefan Neufeind voted on patch set 6 V +1 08/17/15, 22:38

  21. Stefan Neufeind commented on patch set 6 08/17/15, 22:50

    Imho please file a separate issue to unify the language-fetching with PageLayoutController. It's the same functionality. But having it done twice (different; hopefully with same result) is no good idea. Still I'm okay to have it in for now, if we get a followup to unify those two places, with a central and separate tool-method.
  22. Daniel Goerz voted on patch set 6 CR +1 V +1 08/18/15, 06:10

  23. Stefan Neufeind voted on patch set 6 CR +2 V +2 08/18/15, 06:32

  24. Stefan Neufeind merged patch set 6 08/18/15, 06:32

  25. Stefan Neufeind commented on patch set 7 08/18/15, 06:36

    and here the issue to have a central tool-function for language-fetching: https://forge.typo3.org/issues/69144