Review main Merged

27864[BUGFIX] DBAL's quoteFieldNames() returns an empty string

Andreas Kienast CR +2 V +2 Hard +142 −143 updated 09/05/18, 18:49

Commit message

DBAL's DatabaseConnection::INSERTquery() builds an array. The keys
(fields) are mapped through quoteFieldNames(), which returns an empty
string. DBAL's SqlParser tries to use $GLOBALS['TYPO3_DB'], which is
not available here.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 8

Review log 27

Show 2 earlier messages
  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 09/05/18, 18:49

  2. Andreas Kienast updated the commit message in patch set 1 09/05/18, 18:49

  1. Mr. Jenkins commented on patch set 2 09/05/18, 18:49

  2. Mr. Jenkins commented on patch set 3 09/05/18, 18:49

  3. Andreas Kienast uploaded patch set 3 09/05/18, 18:49

  4. Markus Klein commented on patch set 4 CR -1 09/05/18, 18:49

    will push a new change set

    SqlParser.php:49

    trailing spaces

    SqlParser.php:56

    no uppercase variables please. call it $database or $databaseConnection
  5. Mr. Jenkins commented on patch set 4 09/05/18, 18:49

  6. Andreas Kienast commented on patch set 4 09/05/18, 18:49

    Needed to fix the indentions
  7. Andreas Kienast uploaded patch set 4 09/05/18, 18:49

  8. Mr. Jenkins commented on patch set 5 09/05/18, 18:49

  9. Andreas Kienast uploaded patch set 5 09/05/18, 18:49

  10. Markus Klein commented on patch set 7 09/05/18, 18:49

    Hi Andreas, I fixed a lot more in this area now. Please test this patch! Thx a lot!
  11. Markus Klein uploaded patch set 7 09/05/18, 18:49

  12. Mr. Jenkins commented on patch set 6 09/05/18, 18:49

  13. Mr. Jenkins commented on patch set 7 09/05/18, 18:49

  14. Wouter Wolters commented on patch set 7 09/05/18, 18:49

    not able to test this but I have one comment on the change.

    SqlParser.php:82

    This is now listed twice here

    SqlParser.php:132

    Will create a seperate change to cleanup dbal for its usage of tabs
  15. Andreas Kienast uploaded patch set 6 09/05/18, 18:49

  16. Andreas Kienast commented on patch set 7 09/05/18, 18:49

    Hi Markus, thank you for your patches. I give it a try in the office tomorrow.
  17. Markus Klein commented on patch set 8 V +1 CR +1 09/05/18, 18:49

    thanks for testing and pushing
  18. Markus Klein uploaded patch set 9 09/05/18, 18:49

  19. Xavier Perseguers voted on patch set 8 CR +1 09/05/18, 18:49

  20. Mr. Jenkins commented on patch set 8 09/05/18, 18:49

  21. Mr. Jenkins commented on patch set 9 09/05/18, 18:49

  22. Markus Klein commented on patch set 9 V +2 CR +2 09/05/18, 18:49

    Merging this with votes of Xavier and me.
  23. Markus Klein merged patch set 10 09/05/18, 18:49

  24. Andreas Kienast commented on patch set 8 09/05/18, 18:49

    As far as I could test, the patches are working correctly. I just fixed the "$quote $quote" Wouter mentioned in the comments.
  25. Andreas Kienast uploaded patch set 8 09/05/18, 18:49