27864[BUGFIX] DBAL's quoteFieldNames() returns an empty string
Commit message
Review
-
Code review CR +2
- Markus Klein +2
-
Verified V +2
- Markus Klein +2
Issues 1
Files 8
- typo3/sysext/core/Classes/Database/SqlParser.php2+6 −29
- typo3/sysext/dbal/Classes/Database/DatabaseConnection.php+12 −10
- typo3/sysext/dbal/Classes/Database/SqlParser.php2+112 −86
- typo3/sysext/dbal/Tests/Unit/Database/DatabaseConnectionMssqlTest.php+3 −6
- typo3/sysext/dbal/Tests/Unit/Database/DatabaseConnectionOracleTest.php+2 −4
- typo3/sysext/dbal/Tests/Unit/Database/DatabaseConnectionPostgresqlTest.php+2 −4
- typo3/sysext/dbal/Tests/Unit/Database/DatabaseConnectionTest.php+1 −2
- typo3/sysext/dbal/Tests/Unit/Database/SqlParserTest.php+4 −2
Review log 27
Show 2 earlier messages
-
Mr. Jenkins commented on patch set 2 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14324/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14325/ : SUCCESS -
Andreas Kienast uploaded patch set 3 09/05/18, 18:49
-
Markus Klein commented on patch set 4 CR -1 09/05/18, 18:49
will push a new change setSqlParser.php:49trailing spacesSqlParser.php:56no uppercase variables please. call it $database or $databaseConnection -
Mr. Jenkins commented on patch set 4 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14326/ : SUCCESS -
Andreas Kienast commented on patch set 4 09/05/18, 18:49
Needed to fix the indentions -
Andreas Kienast uploaded patch set 4 09/05/18, 18:49
-
Mr. Jenkins commented on patch set 5 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14335/ : SUCCESS -
Andreas Kienast uploaded patch set 5 09/05/18, 18:49
-
Markus Klein commented on patch set 7 09/05/18, 18:49
Hi Andreas, I fixed a lot more in this area now. Please test this patch! Thx a lot! -
Markus Klein uploaded patch set 7 09/05/18, 18:49
-
Mr. Jenkins commented on patch set 6 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14336/ : SUCCESS -
Mr. Jenkins commented on patch set 7 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14339/ : SUCCESS -
Wouter Wolters commented on patch set 7 09/05/18, 18:49
not able to test this but I have one comment on the change.SqlParser.php:82This is now listed twice hereSqlParser.php:132Will create a seperate change to cleanup dbal for its usage of tabs -
Andreas Kienast uploaded patch set 6 09/05/18, 18:49
-
Andreas Kienast commented on patch set 7 09/05/18, 18:49
Hi Markus, thank you for your patches. I give it a try in the office tomorrow. -
Markus Klein commented on patch set 8 V +1 CR +1 09/05/18, 18:49
thanks for testing and pushing -
Markus Klein uploaded patch set 9 09/05/18, 18:49
-
Xavier Perseguers voted on patch set 8 CR +1 09/05/18, 18:49
-
Mr. Jenkins commented on patch set 8 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14366/ : SUCCESS -
Mr. Jenkins commented on patch set 9 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14544/ : SUCCESS -
Markus Klein commented on patch set 9 V +2 CR +2 09/05/18, 18:49
Merging this with votes of Xavier and me. -
Markus Klein merged patch set 10 09/05/18, 18:49
-
Andreas Kienast commented on patch set 8 09/05/18, 18:49
As far as I could test, the patches are working correctly. I just fixed the "$quote $quote" Wouter mentioned in the comments. -
Andreas Kienast uploaded patch set 8 09/05/18, 18:49