27874[BUGFIX] Respect table mapping on caching
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Markus Klein +1
-
Verified V +2
- Xavier Perseguers +2
- Markus Klein +1
Issues 1
Files 1
Review log 30
Show 5 earlier messages
-
Mr. Jenkins commented on patch set 1 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14334/ : SUCCESS -
Wouter Wolters commented on patch set 1 09/05/18, 18:49
Hey Andreas, thanks again for working on DBAL. I have one small comment. Can you fix this small thing? I'm now heading home from work.DatabaseConnection.php:332space after if -
Mr. Jenkins commented on patch set 2 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14337/ : SUCCESS -
Wouter Wolters updated the commit message in patch set 2 09/05/18, 18:49
-
Mr. Jenkins commented on patch set 3 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14346/ : SUCCESS
-
Wouter Wolters commented on patch set 3 CR +1 09/05/18, 18:49
Thanks for fixing:) -
Andreas Kienast commented on patch set 2 09/05/18, 18:49
added space after if -
Andreas Kienast uploaded patch set 2 09/05/18, 18:49
-
Andreas Kienast commented on patch set 3 09/05/18, 18:49
You're welcome. I see, you fixed some silly typos in the commit message. Thank you :) -
Mr. Jenkins commented on patch set 4 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14369/ : SUCCESS -
Andreas Kienast uploaded patch set 4 09/05/18, 18:49
-
Andreas Kienast commented on patch set 4 09/05/18, 18:49
removed translation to original table name which inverts the introduced table mapping -
Andreas Kienast updated the commit message in patch set 4 09/05/18, 18:49
-
Mr. Jenkins commented on patch set 5 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14370/ : SUCCESS -
Andreas Kienast updated the commit message in patch set 5 09/05/18, 18:49
-
Mr. Jenkins commented on patch set 6 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14371/ : SUCCESS -
Wouter Wolters voted on patch set 6 CR +1 09/05/18, 18:49
-
Markus Klein commented on patch set 7 V +1 CR +1 09/05/18, 18:49
Cannot test, but I trust you. So you got my v+1 too when it makes things better for Oracle. -
Markus Klein commented on patch set 7 09/05/18, 18:49
Did you check every usage of $this->mapping if it is accessed with the mapped name and not the original name? -
Xavier Perseguers commented on patch set 7 CR +1 09/05/18, 18:49
I'm still fixing DBAL bugs in the Install Tools step so I did not yet face this bug and cannot test it right now. -
Xavier Perseguers commented on patch set 7 V +2 CR +2 09/05/18, 18:49
Same for me. But this is a typical change so nothing to really worry about, we have lots of work to make DBAL on other DBMS work properly anyway. -
Mr. Jenkins commented on patch set 7 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14556/ : SUCCESS -
Wouter Wolters commented on patch set 7 09/05/18, 18:49
Cherry-pick patchset 6 over a clean master an amend the commut and push again. -
Wouter Wolters wrote 09/05/18, 18:49
Topic set to "dbal". -
Xavier Perseguers merged patch set 8 09/05/18, 18:49
-
Andreas Kienast commented on patch set 7 09/05/18, 18:49
No every usage, but I'm sure the mapped name is always used. Otherwise, the queries would crash with e.g. "Table or view does not exists". Simple CRUD and mm-relatation statements are working. -
Andreas Kienast uploaded patch set 7 09/05/18, 18:49
-
Andreas Kienast commented on patch set 7 09/05/18, 18:49
I faced this bug in the extension manager. -
Andreas Kienast commented on patch set 7 09/05/18, 18:49
This is still required. -
Andreas Kienast commented on patch set 7 09/05/18, 18:49
Oops, I made a commit that was supposed for another issue, but I has some cherry-picks in my repo. How do I revert to patch set #6?