Review main Merged

27879[BUGFIX] Do not save failed token messages in session

Helmut Hummel CR +2 V +2 Easy +14 −5 updated 02/26/14, 20:25

Commit message

In #30272 the backend formprotection has been changed
to not save flash messages in the user session if
the current request is an Ajax request.

Unfortunately the check for that is broken
since the TYPO3_AJAX global is reset in the
bootstrap now.

Introduce a method which uses the request type
constants and adapt the tests accordingly.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 4

  1. Mr. Jenkins commented on patch set 1 02/26/14, 19:33

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 02/26/14, 19:48

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/26/14, 20:25

  4. Anja Leichsenring merged patch set 2 02/26/14, 20:25