Review main Merged

27881[BUGFIX] Filename sorting in filelist is broken

Frans Saris CR +2 V +2 Easy +4 −0 updated 02/27/14, 15:00

Commit message

The sorting by filename in the filelist is broken since the
introduction of sys_file_metadata. It tries to sort the file list
by property file. Before sys_file_metadata it couldn't find this
property and sorted by the default value name. But after introduction
of sys_file_metadata it has an property file, his own sys_file uid.

This patch fixes the sorting behaviour when sorting by filename.

Review

  • Code review CR +2
    • Frans Saris +2
    • Alexander Opitz +1
    • Markus Klein +1
    • Stefan Froemken +1
  • Verified V +2
    • Frans Saris +2
    • Alexander Opitz +1
    • Markus Klein +1
    • Stefan Froemken +1

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 02/26/14, 20:46

  2. Markus Klein voted on patch set 1 V +1 CR +1 02/26/14, 22:15

  3. Alexander Opitz commented on patch set 1 V +1 CR +1 02/27/14, 14:36

    And +1 from colleague at work
  4. Stefan Froemken commented on patch set 1 V +1 CR +1 02/27/14, 14:39

    Only for information: Sorting will only work on files NOT on directories. Directories are always on top.
  5. Frans Saris voted on patch set 1 V +2 CR +2 02/27/14, 15:00

  6. Frans Saris merged patch set 2 02/27/14, 15:00