Review TYPO3_6-1 Abandoned

27903[BUGFIX] Call enableFields in TypoScriptFrontendController

Markus Hölzle CR 0 V 0 Easy +1 −1 updated 03/26/14, 22:26

Commit message

It's not possible to hook enabledFields function if it's not called.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Markus Klein commented on patch set 1 CR -2 02/27/14, 22:38

    Markus, thanks for pushing a patch. Please be aware that patches have to pushed for master branch first and may be targeted for other branches then via the Releases-line of the commit message. Moreover can you please explain in the forge ticket, what this change would do to this very central place of the Core, besides enabling some hook.
  2. Helmut Hummel commented on patch set 1 CR -1 02/27/14, 22:48

    TypoScriptFrontendController.php:1785

    This cannot be changed like this. ->where_groupAccess currently only holds the where clause for group access, which can be enabled or disabled in certain situations enable fields query is hold in ->where_hid_del which also is enabled or disabled in certain situations. At best, this change will blow up the query, but I think (without testing the details) this introduces bugs in that area.
  3. Markus Klein commented on patch set 1 V -1 03/02/14, 19:38

    Please find my comment in the ticket. This fails heavily! (Still, a possible new patch has to be filed for 6.2 first.)
  4. Markus Klein abandoned the change 03/26/14, 22:26

    needs to be for master and needs a complete rewrite