Review main Merged

27932[TASK] Keep the changes to PackageStates.php low

Markus Klein CR +2 V +2 Easy +1 −0 updated 07/24/14, 18:05

Commit message

Introduce a sort operation of the packages before determining
the loading order.
This way the number of changes made to the PackageStates.php file
are reduced.

This is only a first step, further improvements have to be made
to finally resolve #56362.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Susi Moog +1

Issues 1

Files 1

Review log 24

  1. Thomas Maroschik commented on patch set 1 CR +1 02/28/14, 10:10

    So easy :)
  2. Markus Klein commented on patch set 1 02/28/14, 10:11

    Untested!
  3. Mr. Jenkins commented on patch set 1 02/28/14, 10:20

  4. Christian Weiske commented on patch set 1 V -1 02/28/14, 12:22

    I still get unnecessary large diffs when enabling/disabling a single extension - the whole array entry gets moved up or down to a new place, instead of simply changing "active" to "inactive".
  5. Stefan Neufeind commented on patch set 1 03/09/14, 21:32

    @Christian: Is the moving reproducible? I mean, if you activate/deactivate the same package, will the moving part in the file always be the same? If yes, could it be that inactive packages are not taken into account during ordering or so and as such they might end up below all active ones or so?
  6. Christian Weiske commented on patch set 1 03/10/14, 06:49

    @Stefan: You are right. Inactive packages are moved down the array. All inactive ones come after the active ones. When activating the extension again, it's moved up to its previous position.
  7. Thomas Maroschik commented on patch set 1 03/10/14, 07:00

    The moving to the end is by intention. Inactiva packages aren't considered in the sorting algorithm anymore. They can have unment dependencies and resolving these is a tough challenge.
  8. Markus Klein updated the commit message in patch set 1 03/13/14, 11:54

  9. Mr. Jenkins commented on patch set 2 03/13/14, 12:09

  10. Georg Ringer voted on patch set 2 V +1 CR +1 03/13/14, 12:21

  11. Stefan Neufeind commented on patch set 2 CR +1 03/13/14, 12:32

    Definitely makes sense imho to sort them. Should be too much overhead in the end.
  12. Markus Klein commented on patch set 2 CR -2 03/13/14, 13:59

    This patch does not solve the problem of Christian.
  13. Markus Klein abandoned the change 05/06/14, 10:25

    No time to get this further. I'll abandon this for now as the solution is not helpful at all currently.
  14. Markus Klein restored the change 07/24/14, 17:22

    As reported on forge, this patch already makes the diffs smaller. So lets get this in as a first step.
  15. Markus Klein updated the commit message in patch set 3 07/24/14, 17:26

  16. Markus Klein voted on patch set 3 CR 0 07/24/14, 17:27

  17. Markus Klein updated the commit message in patch set 4 07/24/14, 17:30

  18. Stefan Neufeind voted on patch set 4 CR +1 07/24/14, 17:53

  19. Christian Kuhn voted on patch set 4 CR +1 07/24/14, 17:57

  20. Christian Kuhn voted on patch set 4 V +1 07/24/14, 18:00

  21. Susi Moog voted on patch set 4 CR +1 V +1 07/24/14, 18:04

  22. Anja Leichsenring voted on patch set 4 CR +2 V +2 07/24/14, 18:04

  23. Anja Leichsenring merged patch set 4 07/24/14, 18:04

  24. Anja Leichsenring commented on patch set 5 07/24/14, 18:05

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit be7b13a37951e8f6dcc9965cb9088937cba12d23