Review main Merged

27933[BUGFIX] Use HTTP Status 307 for all page shortcut modes

Christoph Dörfel CR +2 V +2 Easy +3 −7 updated 03/19/14, 11:13

Commit message

Fixes cases where the shortcut page is cached by some
devices leading to exceptions or wrong behaviour.

Review

  • Code review CR +2
    • Markus Klein +2
    • Xavier Perseguers +1
  • Verified V +2
    • Markus Klein +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 02/28/14, 10:40

  2. Christoph Dörfel uploaded patch set 2 02/28/14, 10:41

  3. Mr. Jenkins commented on patch set 2 02/28/14, 10:54

  4. Christoph Dörfel voted on patch set 2 CR +1 03/14/14, 07:24

  5. Xavier Perseguers commented on patch set 2 V +1 CR +1 03/17/14, 16:57

    Makes sense indeed. SHORTCUT_MODE_NONE corresponds to specifying a given page as shortcut, which is indeed should be considered as a "permanent redirection" Other types (random, first subpage or parent) are not permanent and are very likely to change over time (parent maybe a little less but still)
  6. Markus Klein commented on patch set 2 03/17/14, 19:21

    Hmmm. Even for NONE a 301 seems to be overdone. You can never safely change that page to any other page type in the future. Permanent redirects have to be placed wisely. Users will only get rid of them by clearing their browser caches, which is done rather seldom to never. So I propose to remove the 301 completely!
  7. Georg Ringer uploaded patch set 3 03/19/14, 05:14

  8. Mr. Jenkins commented on patch set 3 03/19/14, 05:29

  9. Xavier Perseguers voted on patch set 3 V +1 CR +1 03/19/14, 06:15

  10. Markus Klein voted on patch set 3 V +2 CR +2 03/19/14, 11:13

  11. Markus Klein merged patch set 4 03/19/14, 11:13