Review main Merged

27946[BUGFIX] Setting capabilities to readonly show always drag+drop dialog

Rico Sonntag CR +2 V +2 Easy +15 −7 updated 03/04/14, 18:09

Commit message

If a driver is readonly, the upload button in the file list disappears,
but the DragUploader is still activated - on the whole page.
Clicking anywhere on the list page causes an upload file selection to
pop up. Additionally the new button is shown but has no functionality.
The patch removes DragUploader and superfluous button.

Review

  • Code review CR +2
    • Frans Saris +2
    • Rico Sonntag +1
    • Christian Weiske +1
    • Nicole Hummel +1
  • Verified V +2
    • Frans Saris +2
    • Rico Sonntag +1
    • Christian Weiske +1
    • Nicole Hummel +1

Issues 1

Files 1

Review log 19

  1. Rico Sonntag uploaded patch set 2 02/28/14, 14:34

  2. Rico Sonntag uploaded patch set 3 02/28/14, 14:35

  3. Mr. Jenkins commented on patch set 1 02/28/14, 14:48

  4. Mr. Jenkins commented on patch set 2 02/28/14, 14:50

  5. Mr. Jenkins commented on patch set 3 02/28/14, 15:01

  6. Christian Weiske commented on patch set 3 V +1 CR +1 03/03/14, 07:12

    - Drag and Drop upload still works for FAL storage adapters that are writable. - No problems anymore with readonly FAL adapters.
  7. Christian Weiske uploaded patch set 4 03/03/14, 07:16

  8. Christian Weiske commented on patch set 4 V +1 CR +1 03/03/14, 07:17

    My commit only removed the dependency. * Drag and Drop upload still works for FAL storage adapters that are writable. * No problems anymore with readonly FAL adapters.
  9. Rico Sonntag commented on patch set 4 V +1 CR +1 03/03/14, 07:20

    * Drag and Drop upload still works for FAL storage adapters that are writable. * No problems anymore with readonly FAL adapters.
  10. Mr. Jenkins commented on patch set 4 03/03/14, 07:28

  11. Frans Saris voted on patch set 4 CR +1 03/03/14, 12:12

  12. Nicole Hummel uploaded patch set 5 03/03/14, 23:23

  13. Nicole Hummel commented on patch set 5 V +1 CR +1 03/03/14, 23:24

    Added handling for superfluous new button for readonly storages
  14. Mr. Jenkins commented on patch set 5 03/03/14, 23:36

  15. Christian Weiske voted on patch set 5 V +1 CR +1 03/04/14, 06:36

  16. Rico Sonntag voted on patch set 5 V +1 CR +1 03/04/14, 07:40

  17. Frans Saris voted on patch set 5 CR +1 03/04/14, 09:07

  18. Frans Saris voted on patch set 5 V +2 CR +2 03/04/14, 18:07

  19. Wouter Wolters merged patch set 6 03/04/14, 18:09