2799[FEATURE] Show localization mode of field in form
Commit message
Review
-
Code review CR +2
- Steffen Kamper +2
- Stefan Neufeind +1
- Xavier Perseguers +1
-
Verified V +2
- Steffen Kamper +2
- Xavier Perseguers +1
Issues 1
Files 6
- t3lib/stddb/tables.php7+1 −13
- t3lib/class.t3lib_tceforms.php9+34 −12
- typo3/sysext/lang/locallang_misc.xlf+4 −0
- typo3/sysext/t3skin/images/icons/actions/edit-merge-localization.pngnewbinary
- typo3/sysext/t3skin/images/sprites/t3skin.pngbinary
- typo3/sysext/t3skin/stylesheets/sprites/t3skin.css2+476 −472
Review log 33
Show 8 earlier messages
-
Andreas Wolf uploaded patch set 2 08/02/11, 13:43
-
Tolleiv Nietsch commented on patch set 2 08/02/11, 13:43
Verified; I would prefer that you didn't submit this Well it works - but the icon is imho a no-go. Simpel test-scenario: change the header if tt_content in typo3/sysext/cms/tbl_tt_content.php to "mergeIfNotBlank" and see the result when editing a translation. -
Stefan Neufeind commented on patch set 2 2 comments 08/02/11, 13:43
Looks good to me, but someone else must approve general +1, but I'm not sure how "word" slipped into the patch (see inline-comment) -
Stefan Neufeind commented on patch set 2 08/02/11, 13:43
(1 inline comment) -
Stefan Neufeind commented on patch set 2 08/02/11, 13:43
Tolleiv wrote the icon "is a no-go". How can we continue here? Apart from that only smaller things which can easily be taken care of in a next commit. -
Christian Kuhn commented on patch set 1 08/02/11, 13:43
(1 inline comment) Why is the .css file change so big, what did actually change there? Could you give us a simple how-to-test scenario and some pointer where this can be seen in the backend?class.t3lib_tceforms.php:6367protected? -
Jigal van Hemert commented on patch set 1 08/02/11, 13:43
(1 inline comment) The CSS changes are so many because the sprite was regenerated by the sprite generator; there is an icon added. You can ignore this file as far as code review is concerned. The example will be added to forge.class.t3lib_tceforms.php:3388ReplyDoneclass.t3lib_tceforms.php:3398ReplyDoneclass.t3lib_tceforms.php:6230ReplyDoneclass.t3lib_tceforms.php:6367ReplySure. I don't think it's useful anywhere else...tables.php:655I removed this line before pushing and yet it appears again Gerrit :-Stables.php:655ReplyDonetables.php:773I removed this empty line before pushing and yet it appears again in Gerrit :-Stables.php:773ReplyDonet3skin.css:1ReplyAs explained earlier. A new icon means a new sprite, means a zillion changes in the sprite css. -
Xavier Perseguers commented on patch set 3 08/02/11, 13:43
(4 inline comments) Some comments and the patch does not apply anymore.
-
Xavier Perseguers commented on patch set 3 08/02/11, 13:43
(1 inline comment) -
Jigal van Hemert uploaded patch set 3 08/02/11, 13:43
-
Jigal van Hemert commented on patch set 3 08/02/11, 13:43
(6 inline comments) -
Jigal van Hemert commented on patch set 3 08/02/11, 13:43
(2 inline comments) I'll contact the UX/UI guys for a good icon. The icon can be fixed after feature freeze; the functionality is something which has to go in before... -
Jigal van Hemert uploaded patch set 4 08/02/11, 13:43
-
Jigal van Hemert uploaded patch set 5 08/02/11, 13:43
-
Xavier Perseguers uploaded patch set 7 08/02/11, 13:43
-
Xavier Perseguers commented on patch set 7 08/02/11, 13:43
Just fixed the conflict now that XLIFF files have been integrated into Core. -
Xavier Perseguers commented on patch set 7 08/02/11, 13:43
(2 inline comments) About to test it and taking care of those nitpicking -
Stefan Neufeind commented on patch set 9 08/02/11, 13:43
Looks good to me, but someone else must approve -
Steffen Kamper commented on patch set 9 08/02/11, 13:43
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 9 08/02/11, 13:43
Verified; Looks good to me, but someone else must approve Very useful feature! -
Xavier Perseguers uploaded patch set 9 08/02/11, 13:43
-
Jigal van Hemert uploaded patch set 6 08/02/11, 13:43
-
Philipp Gampe commented on patch set 6 08/02/11, 13:43
Verified; Looks good to me, but someone else must approve Quick test and even faster review, but does what is advertised. -
Mr. Jenkins commented on patch set 1 08/02/11, 13:43
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/763/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/02/11, 13:43
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1011/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/02/11, 13:43
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1490/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/02/11, 13:43
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1503/ : SUCCESS -
Mr. Jenkins commented on patch set 5 08/02/11, 13:43
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1505/ : SUCCESS -
Mr. Jenkins commented on patch set 6 08/02/11, 13:43
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1507/ : SUCCESS -
Mr. Jenkins commented on patch set 7 08/02/11, 13:43
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1531/ : SUCCESS -
Mr. Jenkins commented on patch set 9 08/02/11, 13:43
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1532/ : SUCCESS -
Steffen Kamper commented on patch set 9 08/02/11, 13:43
Looks good to me, approved -
Steffen Kamper merged patch set 9 08/02/11, 13:43