Review main Merged

2799[FEATURE] Show localization mode of field in form

Jigal van Hemert CR +2 V +2 Expert +515 −497 updated 06/03/13, 20:49

Commit message

Show an icon in the BE edit form if a field has the l10n_mode
'mergeIfNotBlank'. Editors can now easily see if they can leave the
field blank and the value from the default language will be used.

Review

  • Code review CR +2
    • Steffen Kamper +2
    • Stefan Neufeind +1
    • Xavier Perseguers +1
  • Verified V +2
    • Steffen Kamper +2
    • Xavier Perseguers +1

Issues 1

Files 6

Review log 33

Show 8 earlier messages
  1. Andreas Wolf uploaded patch set 2 08/02/11, 13:43

  2. Tolleiv Nietsch commented on patch set 2 08/02/11, 13:43

    Verified; I would prefer that you didn't submit this Well it works - but the icon is imho a no-go. Simpel test-scenario: change the header if tt_content in typo3/sysext/cms/tbl_tt_content.php to "mergeIfNotBlank" and see the result when editing a translation.
  3. Stefan Neufeind commented on patch set 2 2 comments 08/02/11, 13:43

    Looks good to me, but someone else must approve general +1, but I'm not sure how "word" slipped into the patch (see inline-comment)
  4. Stefan Neufeind commented on patch set 2 08/02/11, 13:43

    (1 inline comment)
  5. Stefan Neufeind commented on patch set 2 08/02/11, 13:43

    Tolleiv wrote the icon "is a no-go". How can we continue here? Apart from that only smaller things which can easily be taken care of in a next commit.
  6. Christian Kuhn commented on patch set 1 08/02/11, 13:43

    (1 inline comment) Why is the .css file change so big, what did actually change there? Could you give us a simple how-to-test scenario and some pointer where this can be seen in the backend?

    class.t3lib_tceforms.php:6367

    protected?
  7. Jigal van Hemert commented on patch set 1 08/02/11, 13:43

    (1 inline comment) The CSS changes are so many because the sprite was regenerated by the sprite generator; there is an icon added. You can ignore this file as far as code review is concerned. The example will be added to forge.

    class.t3lib_tceforms.php:3388 Reply

    Done

    class.t3lib_tceforms.php:3398 Reply

    Done

    class.t3lib_tceforms.php:6230 Reply

    Done

    class.t3lib_tceforms.php:6367 Reply

    Sure. I don't think it's useful anywhere else...

    tables.php:655

    I removed this line before pushing and yet it appears again Gerrit :-S

    tables.php:655 Reply

    Done

    tables.php:773

    I removed this empty line before pushing and yet it appears again in Gerrit :-S

    tables.php:773 Reply

    Done

    t3skin.css:1 Reply

    As explained earlier. A new icon means a new sprite, means a zillion changes in the sprite css.
  8. Xavier Perseguers commented on patch set 3 08/02/11, 13:43

    (4 inline comments) Some comments and the patch does not apply anymore.
  1. Xavier Perseguers commented on patch set 3 08/02/11, 13:43

    (1 inline comment)
  2. Jigal van Hemert uploaded patch set 3 08/02/11, 13:43

  3. Jigal van Hemert commented on patch set 3 08/02/11, 13:43

    (6 inline comments)
  4. Jigal van Hemert commented on patch set 3 08/02/11, 13:43

    (2 inline comments) I'll contact the UX/UI guys for a good icon. The icon can be fixed after feature freeze; the functionality is something which has to go in before...
  5. Jigal van Hemert uploaded patch set 4 08/02/11, 13:43

  6. Jigal van Hemert uploaded patch set 5 08/02/11, 13:43

  7. Xavier Perseguers uploaded patch set 7 08/02/11, 13:43

  8. Xavier Perseguers commented on patch set 7 08/02/11, 13:43

    Just fixed the conflict now that XLIFF files have been integrated into Core.
  9. Xavier Perseguers commented on patch set 7 08/02/11, 13:43

    (2 inline comments) About to test it and taking care of those nitpicking
  10. Stefan Neufeind commented on patch set 9 08/02/11, 13:43

    Looks good to me, but someone else must approve
  11. Steffen Kamper commented on patch set 9 08/02/11, 13:43

    Looks good to me, but someone else must approve
  12. Xavier Perseguers commented on patch set 9 08/02/11, 13:43

    Verified; Looks good to me, but someone else must approve Very useful feature!
  13. Xavier Perseguers uploaded patch set 9 08/02/11, 13:43

  14. Jigal van Hemert uploaded patch set 6 08/02/11, 13:43

  15. Philipp Gampe commented on patch set 6 08/02/11, 13:43

    Verified; Looks good to me, but someone else must approve Quick test and even faster review, but does what is advertised.
  16. Mr. Jenkins commented on patch set 1 08/02/11, 13:43

  17. Mr. Jenkins commented on patch set 2 08/02/11, 13:43

  18. Mr. Jenkins commented on patch set 3 08/02/11, 13:43

  19. Mr. Jenkins commented on patch set 4 08/02/11, 13:43

  20. Mr. Jenkins commented on patch set 5 08/02/11, 13:43

  21. Mr. Jenkins commented on patch set 6 08/02/11, 13:43

  22. Mr. Jenkins commented on patch set 7 08/02/11, 13:43

  23. Mr. Jenkins commented on patch set 9 08/02/11, 13:43

  24. Steffen Kamper commented on patch set 9 08/02/11, 13:43

    Looks good to me, approved
  25. Steffen Kamper merged patch set 9 08/02/11, 13:43