Review main Merged

27995[BUGFIX] Show sectionIndex from referenced page

Nico de Haen CR +2 V +2 Easy +5 −0 updated 05/09/15, 13:49

Commit message

If a page is configured to show content from another pid the menu
of type sectionIndex has to fetch the content elements from the
referenced page instead of the page itself.

Thanks to Christian Finkemeyer for the patch.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stephan Großberndt +1
  • Verified V +2
    • Benni Mack +2
    • Stephan Großberndt +1

Issues 1

Files 1

Review log 27

Show 2 earlier messages
  1. Nico de Haen commented on patch set 1 03/03/14, 14:07

    This patch also needs a Typoscript documentation for the special configuration option: sectionIndex.content_from_pid. I'm not sure where to place it. To test the patch just create a section index on some page and create another page with the "Show content from page" option enabled.
  2. Mr. Jenkins commented on patch set 1 03/03/14, 14:21

  1. Mathias Schreiber commented on patch set 1 V +1 CR -1 12/07/14, 17:21

    Hi Nico, could you add a small rst snipplet in sysext/core/Documentation/Changelog/master/ that decribes the new behavior? It is mandatory so we don't forget to document the news things. Thanks in advance
  2. Mathias Schreiber commented on patch set 1 12/07/14, 17:22

    AbstractMenuContentObject.php:1810

    please supply a stronger check here.
  3. Mathias Schreiber wrote 12/14/14, 16:32

    Topic changed from 46448 to Typoscript
  4. Benni Mack updated the commit message in patch set 2 12/30/14, 15:44

  5. Nico de Haen uploaded patch set 3 01/13/15, 23:00

  6. Mathias Schreiber voted on patch set 3 CR +1 V +1 01/13/15, 23:00

  7. Stephan Großberndt commented on patch set 3 01/26/15, 19:54

    AbstractMenuContentObject.php:1813

    // the section index will be displayed using the given pid

    AbstractMenuContentObject.php:1818

    nitpick: spaces at concatenation ',' . $basePageRow sorry, no dev environment here, otherwise i'd push an update
  8. Stephan Großberndt uploaded patch set 4 03/05/15, 23:26

  9. Stephan Großberndt voted on patch set 4 CR +1 03/05/15, 23:27

  10. Stephan Großberndt uploaded patch set 5 03/05/15, 23:31

  11. Stephan Großberndt commented on patch set 5 CR +1 03/05/15, 23:44

    Renamed rst to follow naming convention, fixed typo in rst
  12. Stephan Großberndt updated the commit message in patch set 6 05/09/15, 00:27

  13. Stephan Großberndt voted on patch set 6 CR +1 05/09/15, 00:27

  14. Stephan Großberndt uploaded patch set 7 05/09/15, 00:53

  15. Stephan Großberndt voted on patch set 7 CR +1 05/09/15, 00:53

  16. Benni Mack uploaded patch set 8 05/09/15, 03:54

  17. Benni Mack voted on patch set 8 CR +1 V +1 05/09/15, 04:00

  18. Stephan Großberndt voted on patch set 8 CR +1 05/09/15, 12:50

  19. Stephan Großberndt commented on patch set 8 CR -1 05/09/15, 13:19

    This patch is not good like this. The configuration option "both" has to be removed again. The options title to configure to show content from another pid is "Replace Content". If you access the page only the content from the other pid is shown. So displaying section headers of content elements of elements on the page is wrong. Setup: - Page A with CE1 and CE2 - Page B witch CE3 and configured to show content from Page A - Page C with CE menu configured to show sectionIndex from Page B Page A and B show only CE 1+2. Page C with "tt_content.menu.20.3.1.sectionIndex.content_from_pid = both" shows CE 1+2+3, but clicking on CE3 it opens Page B and here CE3 is not visible. Page C with "tt_content.menu.20.3.1.sectionIndex.content_from_pid = 1" shows CE 1+2. This is the correct behaviour. But: This should not be a configurable option. This must always be done! Showing a sectionIndex of contents from Page B (CE3) is wrong, if the page is configured to show content from another page. This makes this patch a bugfix again in my opinion and it should be backported.
  20. Stephan Großberndt uploaded patch set 9 05/09/15, 13:27

  21. Stephan Großberndt commented on patch set 9 CR +1 V +1 05/09/15, 13:30

    Using the same setup as mentioned in my last comment: Now the sectionIndex on Page C correctly only displays the sectionIndex of CE 1+2 even though there is CE3 on Page B
  22. Stephan Großberndt commented on patch set 9 05/09/15, 13:40

  23. Benni Mack voted on patch set 9 CR +2 V +2 05/09/15, 13:48

  24. Benni Mack merged patch set 9 05/09/15, 13:48

  25. Benni Mack commented on patch set 10 05/09/15, 13:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit b5aabe849efa68cceeb9e21292632956607e900b