Review main Merged

28000[BUGFIX] Fix warnings on felogin / Use correct usergroup-column

Stefan Neufeind CR +2 V +2 Easy +12 −3 updated 03/03/14, 20:21

Commit message

PHP Warning: Illegal string offset 'usergroup' is shown when
trying to login to the frontend while currently already being
logged into the backend.

Also the usergroup-column needs to be fetched from
$this->fe_user->usergroup_column.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
  • Verified V +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 03/03/14, 19:24

  2. Stefan Neufeind uploaded patch set 2 03/03/14, 19:39

  3. Markus Klein voted on patch set 2 V +1 CR +1 03/03/14, 19:40

  4. Wouter Wolters voted on patch set 2 CR +1 03/03/14, 19:43

  5. Mr. Jenkins commented on patch set 2 03/03/14, 19:52

  6. Stefan Neufeind commented on patch set 2 V -1 03/03/14, 19:53

    Works, but Jigal is working on a small improvement for it.
  7. Jigal van Hemert uploaded patch set 3 03/03/14, 20:08

  8. Stefan Neufeind commented on patch set 3 V +1 CR +1 03/03/14, 20:12

    Great cleanup/addition Jigal. My original case about the warning is still fixed, rechecked that. Also simulating a FE-group as discussed works fine for me.
  9. Jigal van Hemert voted on patch set 3 V +2 CR +2 03/03/14, 20:13

  10. Jigal van Hemert merged patch set 4 03/03/14, 20:13

  11. Mr. Jenkins commented on patch set 3 03/03/14, 20:21