Review main Merged

28010[BUGFIX] Follow up: Remove icon doesn't work

Nicole Hummel CR +2 V +2 Easy +2 −2 updated 03/05/14, 22:43

Commit message

With patch 6711c14 the function setFormValueManipulate was corrected but
if called it returns an array instead of the first form element. This
patch makes sure that the first object is always returned.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 11

  1. Wouter Wolters voted on patch set 1 CR +1 03/03/14, 22:21

  2. Ernesto Baschny commented on patch set 1 03/03/14, 22:24

    Please refer to either a core repository SHA1 or a forge issue, as it's not apparent that this is a Gerrit Change-Id for some by-stander.
    Since this is a minor add-on to the existing fix (which as far as I understood doesn't resolve the problem yet), it should be ok to re-use the existing forge issue number.
  3. Mr. Jenkins commented on patch set 1 03/03/14, 22:32

  4. Nicole Hummel updated the commit message in patch set 1 03/03/14, 22:52

  5. Nicole Hummel updated the commit message in patch set 2 03/03/14, 22:52

  6. Stefan Neufeind voted on patch set 3 CR +1 03/03/14, 22:54

  7. Mr. Jenkins commented on patch set 2 CR -1 V -1 03/03/14, 23:06

  8. Mr. Jenkins commented on patch set 3 03/03/14, 23:16

  9. Markus Klein commented on patch set 3 03/05/14, 22:39

    What does this fix? I don't get a JS warning or error without it and I can remove an entry.
  10. Markus Klein voted on patch set 3 V +2 CR +2 03/05/14, 22:43

  11. Markus Klein merged patch set 4 03/05/14, 22:43