Review main Merged

28035[BUGFIX] Warn about apc.enable_cli=0 on command line

Christian Weiske CR +2 V +2 Easy +3 −0 updated 09/05/18, 18:49

Commit message

When running a CLI script via typo3/cli_dispatch.phpsh,
using the APC caching backend will lead to errors like
> TYPO3 Exception #1232986877: Could not set value.

This patch checks if TYPO3 is running on CLI, and validates the
apc.enable_cli setting to give a proper error message.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Ernesto Baschny +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 03/04/14, 13:37

  2. Christian Kuhn commented on patch set 1 03/04/14, 21:12

    ApcBackend.php:92

    === in both comparisons?
  3. Christian Kuhn updated the commit message in patch set 1 03/04/14, 21:12

  4. Mr. Jenkins commented on patch set 2 03/04/14, 21:25

  5. Christian Weiske commented on patch set 1 03/05/14, 07:15

    ApcBackend.php:92 Reply

    The first is possible, the second not. ini_get always returns a string, even if you use "0" or "Off" as value.
  6. Christian Weiske uploaded patch set 3 03/05/14, 07:17

  7. Mr. Jenkins commented on patch set 3 03/05/14, 07:30

  8. Ernesto Baschny voted on patch set 3 CR +1 03/05/14, 09:48

  9. Wouter Wolters voted on patch set 3 CR +1 03/06/14, 22:20

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 03/07/14, 13:59

  11. Christian Kuhn merged patch set 4 03/07/14, 13:59

  12. Andreas Kienast commented on patch set 3 V +1 CR +1 09/05/18, 18:49

    A simple "php typo3/cli_dispatch.phpsh extbase" throws "The APC backend cannot be used because apc is disabled on CLI." so it looks good to me.