Review main Abandoned

28058[TASK] Move files from toplevel to docs-directory

Stefan Neufeind CR 0 V 0 Easy +1 −0 updated 09/23/14, 09:14

Commit message

Less files in the toplevel-directory.
And we can "protect" things like ChangeLog by
adding a .htaccess.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 16

  1. Stefan Neufeind commented on patch set 1 CR +1 03/04/14, 20:14

    Idea for the docs-directory came from Ernesto (thanks). "Documentation" left in root-dir are just README.md (for github), GPL.txt and LICENSE.txt.
  2. Pascal Dürsteler voted on patch set 1 CR +1 03/04/14, 20:23

  3. Mr. Jenkins commented on patch set 1 03/04/14, 20:25

  4. Georg Ringer commented on patch set 1 03/05/14, 05:53

    can we please remove the .htaccess file and the wording like protect? There is no real security related benefit and I doubt that anyone will symlink the docs dir into the web root.
  5. Pascal Dürsteler commented on patch set 1 03/05/14, 07:56

    I strongly advise to keep the .htaccess there. Not everyone goes the "perfect" way and symlinks sources from outside the acccessible webroot. There are tons of hostings (mostly on usual providers) where you just throw up the files via ftp and start working. Having no .htaccess will lead to information disclosure about the exact bugfix version of a TYPO3 instance, making it attackble through known CVE's. Some may argue that it is not "our business" to keep their setups save, however, I see this as a part of core security. Why open a possible hole if you can keep it shut that simple...
  6. Mathias Brodala voted on patch set 1 CR +1 03/05/14, 11:24

  7. Georg Ringer commented on patch set 1 03/05/14, 12:08

    just as additional information: getting a version is also possible without the changelog file. ;) and yes I am kind of aware of the TYPO3 security process ;)
  8. Xavier Perseguers commented on patch set 1 03/05/14, 18:30

    I don't really like the wording "protect" in commit message either. I'm not +/- for the .htaccess, I really don't care since I agree with Georg about the false sense of security but it still is something and we have it at some places as well. For me it will be of no use anyway since I moved to nginx long ago. Regarding detecting the version, I did it a few years ago and detecting the TYPO3 version (or a small possible range) is really straightforward "from the outside"
  9. Helmut Hummel commented on patch set 1 CR -2 03/05/14, 18:46

    Thanks for the intention to improve TYPO3 CMS security. As pointed out by Xavier and Georg, moving the files to a directory and adding a .htaccess file does not increase security at a level that it is worth doing so. However there might be other reasons why it makes sense to put these files into a subdirectory on top level. Please start a thread on typo3.teams.core to get further opinions on that topic
  10. Felix Kopp commented on patch set 1 CR -1 03/06/14, 00:48

    Do need to do so since sub-directories from typo3_src are linked. Brings problems with Installs, automatic generation/display of README
  11. Frank Nägler commented on patch set 1 09/23/14, 08:15

    Someone is working on this patch?
  12. Stefan Neufeind commented on patch set 1 09/23/14, 08:30

    Can you please not just blindly hit the "reply"-button for each and every review that you find? :-( It's been discussed in length imho, I still would love to see cleanup in this area but others argued against it. Classical deadlock in the TYPO3-community: Time and different views on a certain topic (and, well there are more important things of course).
  13. Wouter Wolters commented on patch set 1 09/23/14, 08:54

    @stefan Frank is doing exactly the same what you do sometimes in the review queue to notify people. Frank is just notifying people to get their attention to cleanup the review system. If this patch is not relevant anymore then abandon it please.
  14. Anja Leichsenring commented on patch set 1 09/23/14, 09:09

    the patch is obsolete imho. We do not maintain the NEWS.md anymore, Changelog has moved to sysext:core. Install.md does no harm. So there is no point to it anymore.
  15. Stefan Neufeind commented on patch set 1 09/23/14, 09:10

    Imho it is still relevant since having a docs-directory since we already have some candidates to be places there and since we also thought where to ship a Nginx-equivalent for the .htaccess-file included. (It's just that Nginx doesn't load a file by default, so it would just be a documentation-file.) Some people that I've talked to or spoke up in this review agreed that having such a directory makes sense. "Protecting" it with a .htaccess was argued for and against. (Imho it's at least a "mini-protection" while others say it's "not really security".)
  16. Stefan Neufeind abandoned the change 09/23/14, 09:14

    Abandoned by popular demand.