Review main Merged

28072[BUGFIX] Fix executable permissions on files

Thomas Luzat CR +2 V +2 Easy +0 −0 updated 03/05/14, 18:33

Commit message

A large number of files were stored with executable permissions. This
may be a (minor) security risk and can be confusing. The patch removes
the executable permissions on all files but:

* typo3/cli_dispatch.phpsh
* typo3/cleaner_check.sh
* typo3/cleaner_fix.sh

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Xavier Perseguers +1
  • Verified V +2
    • Helmut Hummel +2
    • Xavier Perseguers +1

Issues 1

Files 1192

Show 1172 more files

Review log 4

  1. Mr. Jenkins commented on patch set 1 03/05/14, 11:35

  2. Xavier Perseguers commented on patch set 1 V +1 CR +1 03/05/14, 18:25

    Checked by reapplying with: $ find . -type f -exec chmod 644 {} \; $ find . -type d -exec chmod 755 {} \; $ chmod +x typo3/cleaner_fix.sh typo3/cli_dispatch.phpsh typo3/cleaner_check.sh
  3. Helmut Hummel commented on patch set 1 V +2 CR +2 03/05/14, 18:33

    thanks for this one!
  4. Helmut Hummel merged patch set 2 03/05/14, 18:33