Review main Abandoned

28073[BUGFIX] Update foreign_sortby field for IRRE 1:n CSVs

Thomas Luzat CR 0 V 0 Easy +6 −0 updated 12/01/15, 13:29

Commit message

When setting up a 1:n relation IRRE without foreign_field the relation is
stored as a comma-separated list of values. In this case the
foreign_sortby field does not get updated, even though it is used in
other places.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 03/05/14, 11:54

  2. Thomas Luzat uploaded patch set 2 03/05/14, 12:01

  3. Mr. Jenkins commented on patch set 2 03/05/14, 12:14

  4. Mathias Schreiber wrote 12/17/14, 20:37

    Topic set to Datahandler
  5. Alexander Opitz voted on patch set 2 CR +1 06/18/15, 10:29

  6. Frederic Gaus voted on patch set 2 CR +1 06/24/15, 13:19

  7. Andreas Kienast voted on patch set 2 CR +1 06/24/15, 13:25

  8. Daniel Goerz voted on patch set 2 CR +1 07/21/15, 10:06

  9. Daniel Goerz commented on patch set 2 CR 0 08/23/15, 11:42

    Commit message says 6.2 but its actually a patch for master right now.
  10. Alexander Opitz commented on patch set 2 08/24/15, 07:18

    Hi Thomas, can you please rebase your change?
  11. Oliver Hader commented on patch set 2 CR -2 12/01/15, 13:26

    The foreign_sortyby and symmetric_sortyby properties are only available for the foreign_field approach, not for the 1:n CSV approach. This is unfortunately not well documented, which is the reason for me creating an accordant pull request to the documentation (https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-TCA/pull/52). Implementing that behavior for 1:n CSV is not trivial since the serialization order of the parent (string), default sortby, foreign_sortby and symmetric_sortby needs to be implemented and considered for live workspaces, draft workspaces and record localizations as well. The comma-seprated-list behavior on record relations is a topic to be deprecated in TYPO3 CMS 8 however...
  12. Oliver Hader abandoned the change 12/01/15, 13:29

    Since implementing this behavior in DataHandler/RelationHandler for workspaces and localizations is far out of scope, I'm closing this patch-set.