Review main Merged

28076[BUGFIX] Use last result line of identify command

Alexander Stehlik CR +2 V +2 Easy +2 −2 updated 04/01/14, 20:14

Commit message

In GraphicalFunctions::imageMagickIdentify() the last line returned by
the executed command will be used as result.

This prevents the system from using possible error messages printed
before the actual result for further processing.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Xavier Perseguers +1
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 4

  1. Mr. Jenkins commented on patch set 1 03/05/14, 14:03

  2. Xavier Perseguers commented on patch set 1 CR +1 03/17/14, 16:49

    Cannot reproduce as my install is properly working
  3. Stefan Neufeind commented on patch set 1 V +2 CR +2 04/01/14, 20:14

    Not that easy to actually produce an error. But the change itself works fine. And given the demo-output on forge imho thats fine.
  4. Stefan Neufeind merged patch set 2 04/01/14, 20:14