28101[TASK] Deprecate usage of $GLOBALS['typo3CacheManager']
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 42
- typo3/sysext/backend/Classes/Sprite/SpriteManager.php+2 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+4 −4
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php1+1 −1
- typo3/sysext/core/Classes/Cache/Cache.php10+25 −13
- typo3/sysext/core/Classes/Compatibility/GlobalObjectDeprecationDecorator.php2new+69 −0
- typo3/sysext/core/Classes/Core/Bootstrap.php+6 −5
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+9 −21
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php1+24 −7
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+27 −0
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+1 −1
- typo3/sysext/core/Tests/Integrity/IntegrityTest.php+2 −12
- typo3/sysext/core/Tests/Unit/Core/BootstrapTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Localization/Parser/LocallangXmlParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+50 −42
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.phpbinary
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+1 −1
Show 22 more files
- typo3/sysext/extbase/Classes/Object/Container/ClassInfoCache.php+1 −1
- typo3/sysext/extbase/Classes/Object/Container/Container.php+1 −1
- typo3/sysext/extbase/Classes/Scheduler/TaskExecutor.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Scheduler/TaskExecutorTest.php+29 −19
- typo3/sysext/extensionmanager/Classes/Utility/ConfigurationUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php1+9 −2
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+4 −3
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+1 −1
- typo3/sysext/fluid/Classes/View/StandaloneView.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+3 −3
- typo3/sysext/frontend/Classes/Page/PageRepository.php+5 −9
- typo3/sysext/indexed_search/Classes/Controller/IndexedPagesController.php+1 −1
- typo3/sysext/install/Classes/Controller/Action/Step/DatabaseConnect.php+1 −1
- typo3/sysext/install/Classes/Controller/AbstractController.php+1 −1
- typo3/sysext/install/Classes/Service/CachingFrameworkDatabaseSchemaService.php+1 −1
- typo3/sysext/install/Classes/Service/ClearCacheService.php+1 −1
- typo3/sysext/install/Classes/View/StandaloneView.php+1 −1
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionTask.php+1 −1
- typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php2+27 −4
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php2+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −1
Review log 21
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 03/06/14, 13:18
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/14639/ : FAILURE -
Helmut Hummel uploaded patch set 2 03/06/14, 13:43
-
Mr. Jenkins commented on patch set 2 CR -1 V -1 03/06/14, 14:00
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/14642/ : FAILURE -
Markus Klein uploaded patch set 3 03/06/14, 14:13
-
Markus Klein commented on patch set 3 03/06/14, 14:13
Fixed Jenkins -
Mr. Jenkins commented on patch set 3 03/06/14, 14:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14643/ : SUCCESS -
Markus Klein commented on patch set 3 CR -1 03/06/14, 14:47
Cache.php:48what is the reason for having them private? I mean I usually like private stuff, but it's uncommon in TYPO3 CMS ;-)Cache.php:57that should be part of the comment aboveCache.php:85self::$isCachingFrameworkInitialized can never be FALSE when self::$cache* is already initialized.Cache.php:101Why? If self::$* is NULL then we set the singletonInstance to NULL. Ok. if self::$* is not NULL, then we just set the same instances again. What is the benefit? Just set them NULL directly.Cache.php:103unset() vs. directly setting it null. Unset on a static member of a class is a bit weird for my taste.GlobalObjectDeprecationDecorator.php:69trailing spaceCachingFrameworkGarbageCollectionTest.php:44parent::setUp() ?DataHandlerHook.php:31nope!! Documentation is wrong, I'm pretty sure. -
Helmut Hummel uploaded patch set 4 03/06/14, 22:17
-
Mr. Jenkins commented on patch set 4 03/06/14, 22:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14661/ : SUCCESS -
Markus Klein commented on patch set 4 CR +1 03/06/14, 23:03
will test tomorrow -
Helmut Hummel commented on patch set 3 03/06/14, 23:33
Cache.php:48ReplyYeah. In this case I do not want to expose the instances by any means. I also do not need them in tests, so they can be private. Hm, but isCachingFrameworkInitialized is protected. Well, for consistency I change this to protectedCache.php:57ReplyDoneCache.php:85Replytrue, we don't need this any moreCache.php:101Replywrong method call ^^ must be remove singleton instance!Cache.php:103ReplyYeah, also thought about that. Will set them to NULLGlobalObjectDeprecationDecorator.php:69ReplyDoneCachingFrameworkGarbageCollectionTest.php:44Replynone of our tests call parent and all call parent in tearDown ^^ Let's be consistent. We need the parent call in tearDown as we do cleanup stuff in the parent class (not possible otherwise with current phpunit) but we should keep setUp clean.DataHandlerHook.php:31ReplyI really *$%&§"$ that we have a GeneralUtility in Documentation. Could you do me a favor and submit a patch that applies a proper class name to this? I will do anything for you in return... well almost everything ;) -
Christian Kuhn commented on patch set 4 CR -1 03/07/14, 15:34
will push another set.FrontendBackendUserAuthentication.php:263use statement is given. -
Christian Kuhn uploaded patch set 5 03/07/14, 16:03
-
Mr. Jenkins commented on patch set 5 03/07/14, 16:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14689/ : SUCCESS -
Christian Kuhn voted on patch set 5 V +1 CR +1 03/07/14, 16:30
-
Wouter Wolters commented on patch set 5 CR -1 03/07/14, 18:08
ExtensionManagementUtility.php:71wront type here. Should be \TYPO3\CMS\Core\Cache\CacheManagerInstallUtility.php:300why not use $this->cacheManager here? it is injected here.. -
Christian Kuhn uploaded patch set 6 03/07/14, 18:27
-
Christian Kuhn commented on patch set 6 V +1 CR +1 03/07/14, 18:27
fixed wouters remarks. -
Wouter Wolters voted on patch set 6 V +2 CR +2 03/07/14, 18:44
-
Wouter Wolters merged patch set 7 03/07/14, 18:44
-
Mr. Jenkins commented on patch set 6 03/07/14, 18:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14692/ : SUCCESS