28116[BUGFIX] Default size for group-type fields
Commit message
Review
-
Code review CR +2
- Markus Klein +2
-
Verified V +2
- Markus Klein +2
Issues 1
Files 2
Review log 12
-
Mr. Jenkins commented on patch set 1 03/06/14, 17:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14650/ : SUCCESS -
Aske Ertmann commented on patch set 1 03/06/14, 17:48
code looks good, the commit message should probably be improved though -
Francois Suter commented on patch set 1 CR -2 03/06/14, 20:58
I solved a similar issue not long ago (see https://review.typo3.org/#/c/27016/). It is related to the field having no size property, which is indeed the case for the sys_collection table. Fixing the JS is the wrong approach IMO. The sys_collection table definition must be fixed, but this is not enough. I propose to add a default size value for group-type fields. Indeed there are other problems when the size is not defined, like missing controls ("Move selected items to top" and "Move selected items to bottom"). Setting a default value would make sure that a missing size property does not break everything. A value of 5 makes the field look like it does when no size is defined anyway (although that probably depends on the browser anyway). This is not a breaking change for people upgrading, since fields without a size will never have worked properly before. Note that backports to 4.5, 4.7 and 6.0 are only for critical bug fixes. I'll push a new patch with the solution I'm proposing above. -
Francois Suter uploaded patch set 2 03/06/14, 21:09
-
Francois Suter voted on patch set 2 CR 0 03/06/14, 21:09
-
Francois Suter commented on patch set 2 03/06/14, 21:10
I also created a documentation issue, since the default value should be mentioned in the manual. -
Wouter Wolters voted on patch set 2 V +1 CR +1 03/06/14, 21:15
-
Mr. Jenkins commented on patch set 2 03/06/14, 21:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14660/ : SUCCESS -
Markus Klein updated the commit message in patch set 2 03/06/14, 22:55
-
Markus Klein commented on patch set 3 V +2 CR +2 03/06/14, 22:56
Votes of Wouter still valid. Just removed the empty line before the change-id. -
Markus Klein merged patch set 4 03/06/14, 22:56
-
Mr. Jenkins commented on patch set 3 03/06/14, 23:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14667/ : SUCCESS