Review main Merged

28167[CLEANUP] Improve code style for FormEngine::getTSCpid()

Alexander Stehlik CR +2 V +2 Easy +9 −1 updated 03/07/14, 16:39

Commit message

The PHPDoc is fixed. The method returns an array and not an integer.

Additionally the class variable that is used in this method for
storing the cached values is added as a property.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Christian Kuhn +2
    • Tymoteusz Motylewski +1

Issues 1

Files 1

Review log 4

  1. Mr. Jenkins commented on patch set 1 03/07/14, 15:36

  2. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 03/07/14, 15:40

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 03/07/14, 16:39

  4. Christian Kuhn merged patch set 2 03/07/14, 16:39