28168[BUGFIX] Download link for absolute file path
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Wouter Wolters +1
- Christian Weiske +1
-
Verified V +2
- Frans Saris +2
- Christian Weiske +1
Issues 1
Files 1
Review log 18
-
Mr. Jenkins commented on patch set 1 03/07/14, 16:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14691/ : SUCCESS -
Wouter Wolters wrote 03/07/14, 18:12
Topic updated from "56659" to "fal". -
Frans Saris commented on patch set 1 03/07/14, 18:56
ElementInformationController.php:292Is it not posible to use $url = $this->fileObject->getPublicUrl(TRUE); ? -
Christian Weiske commented on patch set 1 CR -1 03/08/14, 07:43
The URL is used several times. Store it in a variable instead and use that. Also, use parse_url($url, PHP_URL_SCHEME) which directly gives you the schema. -
Marian Pollzien uploaded patch set 2 03/10/14, 08:31
-
Mr. Jenkins commented on patch set 2 03/10/14, 08:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14749/ : SUCCESS -
Marian Pollzien uploaded patch set 3 03/10/14, 08:52
-
Marian Pollzien uploaded patch set 4 03/10/14, 09:03
-
Wouter Wolters voted on patch set 4 CR +1 03/10/14, 09:06
-
Mr. Jenkins commented on patch set 3 03/10/14, 09:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14751/ : SUCCESS -
Frans Saris commented on patch set 4 CR -1 03/10/14, 09:28
ElementInformationController.php:291Why the htmlspecialchars? Wasn't there in old situation. -
Wouter Wolters commented on patch set 4 03/10/14, 09:31
ElementInformationController.php:291ReplyPreventing bad guys. See for a similar change https://review.typo3.org/#/c/27670/ -
Christian Weiske commented on patch set 4 03/10/14, 09:34
An FAL adapter can return any URL here, e.g. http://foo/?foo&bar - the & has to be escaped with htmlspecialchars -
Mr. Jenkins commented on patch set 4 03/10/14, 09:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14755/ : SUCCESS -
Christian Weiske commented on patch set 4 V +1 CR +1 03/10/14, 09:35
- Download links now work with FAL adapters that return http:// URLs - Download links still work with the default storage -
Frans Saris commented on patch set 4 CR +1 03/12/14, 13:16
ElementInformationController.php:291Replyok -
Frans Saris voted on patch set 4 V +2 CR +2 03/12/14, 13:18
-
Frans Saris merged patch set 5 03/12/14, 13:18