Review main Merged

28168[BUGFIX] Download link for absolute file path

Marian Pollzien CR +2 V +2 Easy +4 −2 updated 03/12/14, 13:18

Commit message

Support FAL adapters that return absolute urls as public file url

Review

  • Code review CR +2
    • Frans Saris +2
    • Wouter Wolters +1
    • Christian Weiske +1
  • Verified V +2
    • Frans Saris +2
    • Christian Weiske +1

Issues 1

Files 1

Review log 18

  1. Mr. Jenkins commented on patch set 1 03/07/14, 16:44

  2. Wouter Wolters wrote 03/07/14, 18:12

    Topic updated from "56659" to "fal".
  3. Frans Saris commented on patch set 1 03/07/14, 18:56

    ElementInformationController.php:292

    Is it not posible to use $url = $this->fileObject->getPublicUrl(TRUE); ?
  4. Christian Weiske commented on patch set 1 CR -1 03/08/14, 07:43

    The URL is used several times. Store it in a variable instead and use that. Also, use parse_url($url, PHP_URL_SCHEME) which directly gives you the schema.
  5. Marian Pollzien uploaded patch set 2 03/10/14, 08:31

  6. Mr. Jenkins commented on patch set 2 03/10/14, 08:44

  7. Marian Pollzien uploaded patch set 3 03/10/14, 08:52

  8. Marian Pollzien uploaded patch set 4 03/10/14, 09:03

  9. Wouter Wolters voted on patch set 4 CR +1 03/10/14, 09:06

  10. Mr. Jenkins commented on patch set 3 03/10/14, 09:06

  11. Frans Saris commented on patch set 4 CR -1 03/10/14, 09:28

    ElementInformationController.php:291

    Why the htmlspecialchars? Wasn't there in old situation.
  12. Wouter Wolters commented on patch set 4 03/10/14, 09:31

    ElementInformationController.php:291 Reply

    Preventing bad guys. See for a similar change https://review.typo3.org/#/c/27670/
  13. Christian Weiske commented on patch set 4 03/10/14, 09:34

    An FAL adapter can return any URL here, e.g. http://foo/?foo&bar - the & has to be escaped with htmlspecialchars
  14. Mr. Jenkins commented on patch set 4 03/10/14, 09:34

  15. Christian Weiske commented on patch set 4 V +1 CR +1 03/10/14, 09:35

    - Download links now work with FAL adapters that return http:// URLs - Download links still work with the default storage
  16. Frans Saris commented on patch set 4 CR +1 03/12/14, 13:16

    ElementInformationController.php:291 Reply

    ok
  17. Frans Saris voted on patch set 4 V +2 CR +2 03/12/14, 13:18

  18. Frans Saris merged patch set 5 03/12/14, 13:18