Review TYPO3_4-5 Abandoned

28174[BUGFIX] tx_extbase_cache_reflection does not work when igbinary is enabled

Michiel Roos CR 0 V 0 Easy +3 −3 updated 03/31/14, 21:27

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 5

  1. Christian Kuhn commented on patch set 1 CR -1 03/07/14, 21:08

    -1. this db change in 4.5 must be signed-off by Ernesto as RM. If he decides that the change is ok, my vote is obsolete.
  2. Mathias Schreiber commented on patch set 1 V +1 CR +1 03/08/14, 14:57

    I +1 this from a pure DB perspective (and seeing that the field get populated), though I agree with Christian that by principle minor updates should not introduce DB changes. I do understand that the DB change is necessary in order to fix the bug and thus is rather no brainy to me - but unfortunately our stakeholders are used to just patching their release without visiting the DB Analyzer
  3. Michiel Roos commented on patch set 1 03/10/14, 08:57

    The fix we currently use is to add an ext_tables.sql to our own extension. If this does not go in. Please add a not about this to the release notes: # # Table structure for table 'tx_extbase_cache_reflection' # # Fix the reflection cache # https://jira.maxserv.com/browse/CDA-550 # # May be removed when http://forge.typo3.org/issues/56656 is merged. # CREATE TABLE tx_extbase_cache_reflection ( content mediumblob ); # # Table structure for table 'tx_extbase_cache_object' # # Fix the object cache # https://jira.maxserv.com/browse/CDA-550 # # May be removed when http://forge.typo3.org/issues/56656 is merged. # CREATE TABLE tx_extbase_cache_object ( content mediumblob );
  4. Michiel Roos commented on patch set 1 03/10/14, 08:57

    Oops, without the Jira bitx plx
  5. Markus Klein abandoned the change 03/31/14, 21:27

    Ticket is a duplicate. New patch is https://review.typo3.org/29001