Review main Merged

28191[TASK] Include PHP warnings as exceptional errors

Markus Klein CR +2 V +2 Easy +4 −2 updated 03/13/14, 19:05

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 22

  1. Christian Kuhn commented on patch set 1 03/09/14, 13:45

    DevelopmentPreset.php:55

    could we add this as constant for better readability, is that possible already? i don't remember the current state. if not possible, please add a comment with the constants instead.
  2. Christian Kuhn commented on patch set 1 03/09/14, 13:45

    DevelopmentPreset.php:58

    btw: Production -> Development
  3. Markus Klein commented on patch set 1 03/09/14, 13:53

    DevelopmentPreset.php:55 Reply

    don't know, I just had to set it that way in my local conf. will add the constants as comment will make an int as well
  4. Mr. Jenkins commented on patch set 1 03/09/14, 13:54

  5. Markus Klein uploaded patch set 2 03/09/14, 14:03

  6. Markus Klein updated the commit message in patch set 2 03/09/14, 14:04

  7. Mr. Jenkins commented on patch set 2 03/09/14, 14:17

  8. Mr. Jenkins commented on patch set 3 03/09/14, 14:17

  9. Sebastian Fischer voted on patch set 3 CR +1 03/11/14, 17:20

  10. Stefan Neufeind commented on patch set 3 CR +1 03/12/14, 01:05

    DevelopmentPreset.php:55

    nitpick: space before E_RECOVERABLE_ERROR

    DevelopmentPreset.php:56

    didn't check that value - but I expect it's calculated correctly
  11. Christian Kuhn commented on patch set 3 03/12/14, 06:59

    Just to get the impact right: That means if this preset is used, then any warning raised by code will trigger an exception, right?
  12. Patrick Broens voted on patch set 3 CR +1 03/12/14, 08:13

  13. Markus Klein uploaded patch set 4 03/12/14, 09:37

  14. Markus Klein commented on patch set 3 03/12/14, 09:39

    @Christian: Yes this is the intention. I'm using this setting since November all the time and fixed many bugs this way. This setting should encourage ext authors to write better code, as warnings will not easily slip through. If you feel this is too pressing for an ext author, I'm fine with abandoning this change. I just think it's more and more important to "force" coders to a basic code quality. ;-)

    DevelopmentPreset.php:55 Reply

    Done

    DevelopmentPreset.php:56 Reply

    Yes, used the value from my localconf and recalculated it from the docs to be sure.
  15. Mr. Jenkins commented on patch set 4 03/12/14, 09:58

  16. Stefan Neufeind commented on patch set 4 03/12/14, 11:12

    I agree with Markus that a bit more verbose setting for "development" might be a good idea.
  17. Christian Kuhn commented on patch set 4 CR +1 03/12/14, 12:19

    i agree that e_warnings should raise more author attention. with the prod/dev preset this can now be easily done. my question was only towards if i interpreted the change correctly, this is now clear and the change is fine with me.
  18. Wouter Wolters voted on patch set 4 CR +1 03/12/14, 12:19

  19. Stefan Neufeind voted on patch set 4 CR +1 03/12/14, 12:22

  20. Christian Kuhn voted on patch set 4 V +1 03/13/14, 19:03

  21. Anja Leichsenring voted on patch set 4 V +2 CR +2 03/13/14, 19:05

  22. Anja Leichsenring merged patch set 5 03/13/14, 19:05