Review main Merged

28224[BUGFIX] Outside storages can never be marked as public

Fabien Udriot CR +2 V +2 Normal +104 −3 updated 08/19/14, 17:20

Commit message

There are some edge cases where "is_public"
can never be true within a storage record in the BE,
for instance for storage located outside
the document root or for storage driven by special driver
such as Flickr, ...

Review

  • Code review CR +2
    • Frans Saris +2
    • Steffen Ritter +1
  • Verified V +2
    • Frans Saris +2
    • Steffen Ritter +1

Issues 1

Files 4

Review log 11

  1. Mr. Jenkins commented on patch set 1 03/10/14, 14:53

  2. Steffen Ritter commented on patch set 1 03/11/14, 10:00

    in general, this makes sense - I would change three things: 1. the other custom tceforms field reside in Service 2. if the value is overwritten, I would output an additional note aside the value. 3. see inline comment

    StorageCapabilityHook.php:49

    we could take that from TCA
  3. Fabien Udriot uploaded patch set 2 03/12/14, 10:19

  4. Fabien Udriot commented on patch set 2 03/12/14, 10:21

    Comments addressed
  5. Steffen Ritter voted on patch set 2 CR +1 03/12/14, 10:26

  6. Mr. Jenkins commented on patch set 2 03/12/14, 10:38

  7. Steffen Ritter voted on patch set 2 V +1 03/12/14, 11:16

  8. Steffen Ritter wrote 03/12/14, 11:16

    Topic set to "fal".
  9. Frans Saris voted on patch set 2 V +2 CR +2 03/12/14, 11:45

  10. Frans Saris merged patch set 3 03/12/14, 11:45

  11. Markus Klein commented on patch set 3 08/19/14, 17:20

    This seems to break with hidden storages. List module crashes. See https://forge.typo3.org/issues/59017

    UserStorageCapabilityService.php:54

    Does not work if storage is hidden. StorageRepository::findByUid() uses the enable fields, hence this storage can never be retrieved.