28224[BUGFIX] Outside storages can never be marked as public
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Steffen Ritter +1
-
Verified V +2
- Frans Saris +2
- Steffen Ritter +1
Issues 1
Files 4
Review log 11
-
Mr. Jenkins commented on patch set 1 03/10/14, 14:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14785/ : SUCCESS -
Steffen Ritter commented on patch set 1 03/11/14, 10:00
in general, this makes sense - I would change three things: 1. the other custom tceforms field reside in Service 2. if the value is overwritten, I would output an additional note aside the value. 3. see inline commentStorageCapabilityHook.php:49we could take that from TCA -
Fabien Udriot uploaded patch set 2 03/12/14, 10:19
-
Fabien Udriot commented on patch set 2 03/12/14, 10:21
Comments addressed -
Steffen Ritter voted on patch set 2 CR +1 03/12/14, 10:26
-
Mr. Jenkins commented on patch set 2 03/12/14, 10:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14925/ : SUCCESS -
Steffen Ritter voted on patch set 2 V +1 03/12/14, 11:16
-
Steffen Ritter wrote 03/12/14, 11:16
Topic set to "fal". -
Frans Saris voted on patch set 2 V +2 CR +2 03/12/14, 11:45
-
Frans Saris merged patch set 3 03/12/14, 11:45
-
Markus Klein commented on patch set 3 08/19/14, 17:20
This seems to break with hidden storages. List module crashes. See https://forge.typo3.org/issues/59017UserStorageCapabilityService.php:54Does not work if storage is hidden. StorageRepository::findByUid() uses the enable fields, hence this storage can never be retrieved.