Review main Merged

28227[BUGFIX] Multiple Set-Cookie headers for deleting FE cookie

Nicole Hummel CR +2 V +2 Easy +4 −2 updated 03/10/14, 21:37

Commit message

In the current master every time when removeCookie is triggered a
Set-Cookie header is generated. A cookie should only be deleted if it
was set before. As removeCookie can handle different cookie names, the
check is performed before calling removeCookie function.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Alexander Opitz +1
    • Oliver Klee +1
  • Verified V +2
    • Jigal van Hemert +2
    • Alexander Opitz +1

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 03/10/14, 15:41

  2. Alexander Opitz commented on patch set 1 CR -1 03/10/14, 16:03

    AbstractUserAuthentication.php:979

    This does not test for the cookieName that should be removed Move this functionality to a cookie management class after 6.2?
  3. Nicole Hummel uploaded patch set 2 03/10/14, 17:06

  4. Alexander Opitz voted on patch set 2 V +1 CR +1 03/10/14, 17:16

  5. Mr. Jenkins commented on patch set 2 03/10/14, 17:20

  6. Oliver Klee commented on patch set 2 CR +1 03/10/14, 17:28

    However, I'd prefer we add a method "removeCookieIfSet" that is called by both places. Then we could also remove the comment.
  7. Jigal van Hemert voted on patch set 2 V +2 CR +2 03/10/14, 21:37

  8. Jigal van Hemert merged patch set 3 03/10/14, 21:37