28227[BUGFIX] Multiple Set-Cookie headers for deleting FE cookie
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Alexander Opitz +1
- Oliver Klee +1
-
Verified V +2
- Jigal van Hemert +2
- Alexander Opitz +1
Issues 1
Files 1
Review log 8
-
Mr. Jenkins commented on patch set 1 03/10/14, 15:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14792/ : SUCCESS -
Alexander Opitz commented on patch set 1 CR -1 03/10/14, 16:03
AbstractUserAuthentication.php:979This does not test for the cookieName that should be removed Move this functionality to a cookie management class after 6.2? -
Nicole Hummel uploaded patch set 2 03/10/14, 17:06
-
Alexander Opitz voted on patch set 2 V +1 CR +1 03/10/14, 17:16
-
Mr. Jenkins commented on patch set 2 03/10/14, 17:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14799/ : SUCCESS -
Oliver Klee commented on patch set 2 CR +1 03/10/14, 17:28
However, I'd prefer we add a method "removeCookieIfSet" that is called by both places. Then we could also remove the comment. -
Jigal van Hemert voted on patch set 2 V +2 CR +2 03/10/14, 21:37
-
Jigal van Hemert merged patch set 3 03/10/14, 21:37