28234[TASK] Simplify TYPO3_DB->cleanIntArray
Commit message
Review
-
Code review CR +2
- Dmitry Dulepov +2
- Christian Kuhn +2
-
Verified V +2
- Dmitry Dulepov +2
- Christian Kuhn +2
Issues 1
Files 2
Review log 11
-
Mr. Jenkins commented on patch set 1 03/10/14, 17:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14802/ : SUCCESS -
Markus Klein commented on patch set 1 03/10/14, 17:50
I'm for removing this function. It has only 8 usage. So do the array_map directly there and deprecate the function.6.0 is in important bugfix mode, no backport -
Oliver Klee commented on patch set 1 03/10/14, 19:03
I agree. -
Bernhard Kraft commented on patch set 1 03/18/14, 08:11
Maybe we should leave it there. AFAIK calling a method is not that expensive. At least less expensive than iterating over an array with quite some elements. If we would write assembler here (like I do currently: PIC assembler :) I would suggest to let it be a macro. Also stuff which recently became necessary for TYPO3 development. Like: if (isset($variable[$key]) && $variable[$key]) { could get replaced by something like if (ASSERT_KEY($variable, $key)) { ... but sadly there are no macros for PHP. There is a discussion about their usefulness and if they would improve readability/execution/speed: http://bytes.com/topic/php/answers/477779-macros-php I vote for leaving cleanIntArray there. For the sake of readability. -
Christian Kuhn commented on patch set 1 03/18/14, 08:24
could this method please get a couple of simple unit tests to prove behavior is not changed? -
Christian Kuhn voted on patch set 1 CR -1 03/18/14, 08:24
-
Bernhard Kraft uploaded patch set 2 03/18/14, 12:26
-
Mr. Jenkins commented on patch set 2 03/18/14, 12:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15268/ : SUCCESS -
Dmitry Dulepov commented on patch set 2 V +2 CR +2 03/18/14, 13:11
Tested, works. Unit tests pass. -
Christian Kuhn commented on patch set 2 V +2 CR +2 03/18/14, 13:33
thx! -
Christian Kuhn merged patch set 3 03/18/14, 13:33