Review main Merged

28253[TASK] Update ADOdb to 5.18

Andreas Kienast CR +2 V +2 Impossible +5972 −5383 updated 09/05/18, 18:49

Commit message

Update ADOdb to current version 5.18 which fixes various bugs
and adds PHP 5.4 compatibility.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1
  • Verified V +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1

Issues 1

Files 134

Show 114 more files

Review log 16

  1. Mr. Jenkins commented on patch set 1 09/05/18, 18:49

  2. Xavier Perseguers commented on patch set 2 CR -1 09/05/18, 18:49

    Please merge fix from #48034 onto this patch, it does not work for me
  3. Mr. Jenkins commented on patch set 2 09/05/18, 18:49

  4. Andreas Kienast uploaded patch set 2 09/05/18, 18:49

  5. Andreas Kienast commented on patch set 2 09/05/18, 18:49

    Removed trailing whitespaces
  6. Markus Klein commented on patch set 3 09/05/18, 18:49

    Please add a README to the adodb folder that it is not usable ootb. maybe also link that patch.
  7. Xavier Perseguers commented on patch set 3 V +1 09/05/18, 18:49

    I agree with Markus here
  8. Ernesto Baschny commented on patch set 4 09/05/18, 18:49

    Looks like we need this in 6.2 LTS, thanks for taking care!
  9. Xavier Perseguers commented on patch set 4 V +1 CR +1 09/05/18, 18:49

    README.txt file added (.txt to be in line with various similar files in other extensions)
  10. Xavier Perseguers uploaded patch set 4 09/05/18, 18:49

  11. Mr. Jenkins commented on patch set 3 09/05/18, 18:49

  12. Mr. Jenkins commented on patch set 4 09/05/18, 18:49

  13. Jigal van Hemert voted on patch set 4 V +2 CR +2 09/05/18, 18:49

  14. Jigal van Hemert merged patch set 5 09/05/18, 18:49

  15. Andreas Kienast uploaded patch set 3 09/05/18, 18:49

  16. Andreas Kienast commented on patch set 3 09/05/18, 18:49

    merged #48034