Review main Merged

28254[BUGFIX] DatabaseConnection must be initialized

Xavier Perseguers CR +2 V +2 Easy +2 −0 updated 09/05/18, 18:49

Commit message

The install tool forgets to initialize the database connection.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +1

Files 2

Review log 11

  1. Mr. Jenkins commented on patch set 1 03/11/14, 14:07

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 03/11/14, 14:08

  3. Xavier Perseguers commented on patch set 1 03/11/14, 14:20

    Yeah, I have it as well, that's another problem. Without this fix (and it's a much as done in Bootstrap's initializeTypo3DbGlobal()), I get a white page without any error while opening install tool and having valid credentials configured. By debugging I've seen that even though I have oci8 as driver, it's not read and uses default config which is "native"
  4. Xavier Perseguers commented on patch set 1 03/11/14, 14:23

    actually it's the same problem, another place is missing this fix...
  5. Xavier Perseguers uploaded patch set 2 03/11/14, 14:45

  6. Mr. Jenkins commented on patch set 2 03/11/14, 15:05

  7. Xavier Perseguers wrote 03/11/14, 15:14

    Topic set to "dbal".
  8. Markus Klein commented on patch set 2 V +2 CR +2 03/11/14, 17:40

    Yep, my mistake when I added the initialize method.
  9. Markus Klein merged patch set 3 03/11/14, 17:40

  10. Andreas Kienast commented on patch set 1 09/05/18, 18:49

    After cherry-pick, the install tool uses mysqli for no reason. But I think it's an issue caused by #50752.
  11. Andreas Kienast commented on patch set 2 V +1 CR +1 09/05/18, 18:49

    This works now :) I made a similar commit a few seconds ago, I guess we can abandon it.