28255[BUGFIX] Language labels taken from wrong language file
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Sebastian Kieper +1
-
Verified V +2
- Wouter Wolters +2
- Sebastian Kieper +1
Issues 1
Files 1
Review log 19
-
Ernesto Baschny commented on patch set 1 CR -2 03/11/14, 14:12
Moving labels is not possible because these locallang files are being used also in older releases, and have probably translations. So either change the calling part to refer to the original locallang file, or add "new labels". -
Mr. Jenkins commented on patch set 1 03/11/14, 14:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14837/ : SUCCESS -
Patrick Broens uploaded patch set 2 03/11/14, 14:23
-
Patrick Broens uploaded patch set 3 03/11/14, 14:31
-
Mr. Jenkins commented on patch set 2 03/11/14, 14:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14839/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/11/14, 14:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14841/ : SUCCESS -
Patrick Broens uploaded patch set 4 03/11/14, 15:14
-
Mr. Jenkins commented on patch set 4 03/11/14, 16:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14852/ : SUCCESS -
Patrick Broens uploaded patch set 5 03/11/14, 16:20
-
Mr. Jenkins commented on patch set 5 03/11/14, 17:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14865/ : SUCCESS -
Ernesto Baschny voted on patch set 5 CR 0 03/11/14, 18:48
-
Sebastian Fischer voted on patch set 5 V +1 CR +1 03/11/14, 19:14
-
Wouter Wolters commented on patch set 5 CR -1 03/11/14, 20:32
-1 is to prevent mergingPageInformationController.php:50Why introduce extbase here, while "$LANG->sL('LLL:EXT:cms/web_info/locallang.xlf:pages_0')," also works.. -
Patrick Broens uploaded patch set 6 03/12/14, 08:33
-
Wouter Wolters voted on patch set 6 V +1 CR +1 03/12/14, 08:36
-
Mr. Jenkins commented on patch set 6 03/12/14, 08:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14910/ : SUCCESS -
Sebastian Kieper voted on patch set 6 V +1 CR +1 03/12/14, 09:19
-
Wouter Wolters voted on patch set 6 V +2 CR +2 03/12/14, 09:21
-
Wouter Wolters merged patch set 7 03/12/14, 09:21