Review main Merged

28255[BUGFIX] Language labels taken from wrong language file

Patrick Broens CR +2 V +2 Easy +7 −7 updated 03/12/14, 09:21

Commit message

The module "Pagetree overview" in Web > Info is showing an empty
selectbox because the language labels for this dropdown are called from
the wrong language file.

This patch changes the calls to the language labels

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Sebastian Kieper +1
  • Verified V +2
    • Wouter Wolters +2
    • Sebastian Kieper +1

Issues 1

Files 1

Review log 19

  1. Ernesto Baschny commented on patch set 1 CR -2 03/11/14, 14:12

    Moving labels is not possible because these locallang files are being used also in older releases, and have probably translations. So either change the calling part to refer to the original locallang file, or add "new labels".
  2. Mr. Jenkins commented on patch set 1 03/11/14, 14:16

  3. Patrick Broens uploaded patch set 2 03/11/14, 14:23

  4. Patrick Broens uploaded patch set 3 03/11/14, 14:31

  5. Mr. Jenkins commented on patch set 2 03/11/14, 14:37

  6. Mr. Jenkins commented on patch set 3 03/11/14, 14:50

  7. Patrick Broens uploaded patch set 4 03/11/14, 15:14

  8. Mr. Jenkins commented on patch set 4 03/11/14, 16:10

  9. Patrick Broens uploaded patch set 5 03/11/14, 16:20

  10. Mr. Jenkins commented on patch set 5 03/11/14, 17:39

  11. Ernesto Baschny voted on patch set 5 CR 0 03/11/14, 18:48

  12. Sebastian Fischer voted on patch set 5 V +1 CR +1 03/11/14, 19:14

  13. Wouter Wolters commented on patch set 5 CR -1 03/11/14, 20:32

    -1 is to prevent merging

    PageInformationController.php:50

    Why introduce extbase here, while "$LANG->sL('LLL:EXT:cms/web_info/locallang.xlf:pages_0')," also works..
  14. Patrick Broens uploaded patch set 6 03/12/14, 08:33

  15. Wouter Wolters voted on patch set 6 V +1 CR +1 03/12/14, 08:36

  16. Mr. Jenkins commented on patch set 6 03/12/14, 08:46

  17. Sebastian Kieper voted on patch set 6 V +1 CR +1 03/12/14, 09:19

  18. Wouter Wolters voted on patch set 6 V +2 CR +2 03/12/14, 09:21

  19. Wouter Wolters merged patch set 7 03/12/14, 09:21