Review main Merged

28261[BUGFIX] PHP Runtime Notice in saltedpasswords

Xavier Perseguers CR +2 V +2 Easy +2 −1 updated 09/05/18, 18:49

Commit message

Declaration of method compareUident() should be compatible with its
parent class.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Files 1

Review log 4

  1. Mr. Jenkins commented on patch set 1 03/11/14, 16:24

  2. Wouter Wolters voted on patch set 1 V +2 CR +2 03/11/14, 16:26

  3. Wouter Wolters merged patch set 2 03/11/14, 16:26

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 09/05/18, 18:49