Review main Merged

28290[BUGFIX] Missing icons for some core db tables

Frans Saris CR +2 V +2 Easy +14 −2 updated 03/13/14, 20:51

Commit message

The records of EXT:extensionmanager are also set to adminOnly=TRUE

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Xavier Perseguers +1
  • Verified V +2
    • Anja Leichsenring +2
    • Xavier Perseguers +1

Issues 1

Files 4

Review log 11

  1. Steffen Ritter commented on patch set 1 CR -1 03/12/14, 11:18

    tx_extensionmanager_domain_model_extension.php:8

    can we please use a sprite icon here too

    tx_extensionmanager_domain_model_repository.php:8

    please use sprite icon
  2. Mr. Jenkins commented on patch set 1 03/12/14, 11:24

  3. Frans Saris uploaded patch set 2 03/12/14, 12:10

  4. Mr. Jenkins commented on patch set 2 03/12/14, 12:34

  5. Georg Ringer uploaded patch set 3 03/13/14, 08:30

  6. Wouter Wolters commented on patch set 3 CR +1 03/13/14, 08:34

  7. Mr. Jenkins commented on patch set 3 03/13/14, 08:45

  8. Markus Klein voted on patch set 3 CR +1 03/13/14, 20:26

  9. Xavier Perseguers voted on patch set 3 V +1 CR +1 03/13/14, 20:29

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 03/13/14, 20:51

  11. Anja Leichsenring merged patch set 4 03/13/14, 20:51