Review main Merged

28319[TASK] Remove deprecated initCharset from DocumentTemplate

Wouter Wolters CR +2 V +2 Easy +0 −15 updated 03/13/14, 05:25

Commit message

Removes also the deprecated method initCharset

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 9

  1. Wouter Wolters uploaded patch set 2 03/12/14, 19:17

  2. Mr. Jenkins commented on patch set 1 03/12/14, 20:31

  3. Mr. Jenkins commented on patch set 2 03/12/14, 20:45

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 03/12/14, 22:49

  5. Christian Kuhn updated the commit message in patch set 2 03/12/14, 22:54

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 03/12/14, 22:55

  7. Mr. Jenkins commented on patch set 3 03/12/14, 23:07

  8. Georg Ringer voted on patch set 3 V +2 CR +2 03/13/14, 05:25

  9. Georg Ringer merged patch set 4 03/13/14, 05:25