Review main Merged

28335[TASK] Remove checks for extensions which are always loaded

Georg Ringer CR +2 V +2 Hard +135 −174 updated 03/13/14, 12:32

Commit message

There are several calls to check if extensions like extbase are loaded.
As those extensions cannot be removed and are always loaded,
the code can be removed.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Markus Klein +1

Issues 1

Files 20

Review log 7

  1. Mr. Jenkins commented on patch set 1 03/13/14, 08:39

  2. Markus Klein voted on patch set 1 V +1 CR +1 03/13/14, 09:41

  3. Stefan Neufeind commented on patch set 1 CR +1 03/13/14, 11:06

    This targets extensions cms and recordlist. Checked that they have partOfMinimalUsableSystem in their Package.php. Should be safe to go this way imho.
  4. Oliver Klee voted on patch set 1 CR +1 03/13/14, 11:30

  5. Stefan Neufeind commented on patch set 1 V +1 03/13/14, 12:25

    Also saltedpasswords. Checked BE/FE and spotted no problems. The changes in code are "quite a few" but low-critical imho (by reading) and easy.
  6. Georg Ringer voted on patch set 1 V +2 CR +2 03/13/14, 12:32

  7. Georg Ringer merged patch set 2 03/13/14, 12:32