28342[BUGFIX] Show thumbnails in list module
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Alexander Opitz +1
- Andreas Kießling +1
-
Verified V +2
- Markus Klein +2
- Alexander Opitz +1
- Andreas Kießling +1
Issues 1
Files 1
Review log 16
-
Markus Klein commented on patch set 1 03/13/14, 11:32
untested -
Mr. Jenkins commented on patch set 1 03/13/14, 11:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15038/ : SUCCESS -
Frans Saris commented on patch set 1 03/13/14, 13:36
DatabaseRecordList.php:659tabs should be removed -
Markus Klein commented on patch set 1 03/13/14, 14:33
DatabaseRecordList.php:659ReplyDone -
Markus Klein uploaded patch set 2 03/13/14, 14:33
-
Markus Klein uploaded patch set 3 03/13/14, 14:34
-
Andreas Kießling commented on patch set 3 V -1 03/13/14, 14:43
Does not work, if no type column is set. If the setting is missing, 0 and 1 need to be checked as fallback. I have currently no setup to push a new changeset.DatabaseRecordList.php:648If no type column is set, this fails and thus no thumbs are shown. -
Mr. Jenkins commented on patch set 2 03/13/14, 14:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15048/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/13/14, 14:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15049/ : SUCCESS -
Markus Klein uploaded patch set 4 03/13/14, 14:51
-
Andreas Kießling commented on patch set 4 V +1 CR +1 03/13/14, 14:57
Works with my current extension. Thanks! -
Mr. Jenkins commented on patch set 4 03/13/14, 15:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15050/ : SUCCESS -
Alexander Opitz voted on patch set 4 V +1 CR +1 03/13/14, 15:12
-
Markus Klein voted on patch set 4 V +2 CR +2 03/13/14, 15:19
-
Markus Klein merged patch set 5 03/13/14, 15:19
-
Markus Klein commented on patch set 5 03/13/14, 15:19
Cherry Picked This patchset was cherry picked to change: Ifafdb0c51266c76620696c6d94471b3efddba112