Review main Merged

28342[BUGFIX] Show thumbnails in list module

Markus Klein CR +2 V +2 Easy +9 −2 updated 03/13/14, 15:19

Commit message

Add missing checks if type column exists in a row.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
    • Andreas Kießling +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1
    • Andreas Kießling +1

Issues 1

Files 1

Review log 16

  1. Markus Klein commented on patch set 1 03/13/14, 11:32

    untested
  2. Mr. Jenkins commented on patch set 1 03/13/14, 11:45

  3. Frans Saris commented on patch set 1 03/13/14, 13:36

    DatabaseRecordList.php:659

    tabs should be removed
  4. Markus Klein commented on patch set 1 03/13/14, 14:33

    DatabaseRecordList.php:659 Reply

    Done
  5. Markus Klein uploaded patch set 2 03/13/14, 14:33

  6. Markus Klein uploaded patch set 3 03/13/14, 14:34

  7. Andreas Kießling commented on patch set 3 V -1 03/13/14, 14:43

    Does not work, if no type column is set. If the setting is missing, 0 and 1 need to be checked as fallback. I have currently no setup to push a new changeset.

    DatabaseRecordList.php:648

    If no type column is set, this fails and thus no thumbs are shown.
  8. Mr. Jenkins commented on patch set 2 03/13/14, 14:48

  9. Mr. Jenkins commented on patch set 3 03/13/14, 14:48

  10. Markus Klein uploaded patch set 4 03/13/14, 14:51

  11. Andreas Kießling commented on patch set 4 V +1 CR +1 03/13/14, 14:57

    Works with my current extension. Thanks!
  12. Mr. Jenkins commented on patch set 4 03/13/14, 15:05

  13. Alexander Opitz voted on patch set 4 V +1 CR +1 03/13/14, 15:12

  14. Markus Klein voted on patch set 4 V +2 CR +2 03/13/14, 15:19

  15. Markus Klein merged patch set 5 03/13/14, 15:19

  16. Markus Klein commented on patch set 5 03/13/14, 15:19

    Cherry Picked This patchset was cherry picked to change: Ifafdb0c51266c76620696c6d94471b3efddba112