Review main Merged

28359[BUGFIX] Warnings in ArrayUtility with some PHP versions

Christian Kuhn CR +2 V +2 Easy +6 −1 updated 03/13/14, 20:40

Commit message

PHP issue https://bugs.php.net/bug.php?id=50688 triggers a warning
in ArrayUtility::sortArraysByKey() on some supported PHP versions
like debian wheezy 5.4.4. Since this is a language error and the
code itself is correct and covered by unit tests, the warning is
now suppressed using the @ operator.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 4

  1. Markus Klein voted on patch set 1 V +1 CR +1 03/13/14, 20:17

  2. Mr. Jenkins commented on patch set 1 03/13/14, 20:32

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 03/13/14, 20:40

  4. Wouter Wolters merged patch set 2 03/13/14, 20:40