Review main Merged

28371[BUGFIX] FunctionalTestCaseBootstrapUtility throws warnings on Windows

Nicole Hummel CR +2 V +2 Easy +6 −2 updated 03/13/14, 23:24

Commit message

If the FunctionalTestCaseBootstrapUtility::removeInstance() tries to
delete an existing symlink to a folder, the function unlink() is used.
This leads to a warning on Windows systems because unlink can only
delete files and symlinks to files.
This patch adds a rmdir() call for symlinks which works for Windows
system as well.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 3

  1. Stefan Neufeind commented on patch set 1 V +2 CR +2 03/13/14, 23:18

    Simple and I expect Nicole tested it throughly. We won't have too many people on Windows to try running function-tests shortly imho. So let's get this in imho.
  2. Stefan Neufeind merged patch set 2 03/13/14, 23:18

  3. Mr. Jenkins commented on patch set 1 03/13/14, 23:24