Review main Merged

28393[BUGFIX] Fix automatic core updater

Andreas Kienast CR +2 V +2 Easy +3 −5 updated 09/05/18, 18:49

Commit message

AbstractCoreUpdate redefines the $view member to be
a JsonView, but does not re-implement the parent methods
that rely on $view being an AbstractView.

Fix this by re-implementing the initializeHandle() method.
This method can be merged with the former initializeCoreUpdate(),
which wasn't called at all in most actions.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
    • Philipp Gampe +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 25

  1. Mr. Jenkins commented on patch set 1 09/05/18, 18:49

  2. Mr. Jenkins commented on patch set 2 09/05/18, 18:49

  3. Andreas Kienast commented on patch set 2 09/05/18, 18:49

    Please note: This patch does not completely solve the problem. After applying this patch, it crashes because of "Call to a member function exec_SELECTquery() on a non-object in typo3/sysext/core/Classes/Registry.php on line 86"

    AbstractCoreUpdate.php:63

    This resolves the database connection problem, but I'm not sure if this is the right place.
  4. Andreas Kienast uploaded patch set 2 09/05/18, 18:49

  5. Markus Klein uploaded patch set 4 09/05/18, 18:49

  6. Markus Klein uploaded patch set 5 09/05/18, 18:49

  7. Markus Klein uploaded patch set 6 09/05/18, 18:49

  8. Markus Klein updated the commit message in patch set 6 09/05/18, 18:49

  9. Markus Klein updated the commit message in patch set 7 09/05/18, 18:49

  10. Markus Klein commented on patch set 8 V +2 CR +2 09/05/18, 18:49

    Since I refactored this back then, I know what I did wrong. ;-)
  11. Markus Klein merged patch set 9 09/05/18, 18:49

  12. Christian Kuhn commented on patch set 3 CR -1 09/05/18, 18:49

    I don't think changing typo3/sysext/extbase/Classes/Mvc/View/AbstractView.php is the correct approach to fix this issue, imho a bugfix should stay within ext:install? ... will review, but not not, give me some time.
  13. Christian Kuhn commented on patch set 3 09/05/18, 18:49

    up. we need to fix this. will dig into this tomorrow evening.
  14. Christian Kuhn commented on patch set 6 09/05/18, 18:49

    thx! will review tomorrow :)
  15. Christian Kuhn voted on patch set 7 V +1 CR +1 09/05/18, 18:49

  16. Christian Kuhn voted on patch set 8 V +1 CR +1 09/05/18, 18:49

  17. Philipp Gampe voted on patch set 8 CR +1 09/05/18, 18:49

  18. Mr. Jenkins commented on patch set 3 09/05/18, 18:49

  19. Mr. Jenkins commented on patch set 4 09/05/18, 18:49

  20. Mr. Jenkins commented on patch set 5 09/05/18, 18:49

  21. Mr. Jenkins commented on patch set 6 09/05/18, 18:49

  22. Mr. Jenkins commented on patch set 7 09/05/18, 18:49

  23. Mr. Jenkins commented on patch set 8 09/05/18, 18:49

  24. Andreas Kienast uploaded patch set 3 09/05/18, 18:49

  25. Andreas Kienast commented on patch set 3 1 comment 09/05/18, 18:49