28393[BUGFIX] Fix automatic core updater
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Christian Kuhn +1
- Philipp Gampe +1
-
Verified V +2
- Markus Klein +2
- Christian Kuhn +1
Issues 1
Files 3
Review log 25
-
Mr. Jenkins commented on patch set 1 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15094/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15095/ : SUCCESS -
Andreas Kienast commented on patch set 2 09/05/18, 18:49
Please note: This patch does not completely solve the problem. After applying this patch, it crashes because of "Call to a member function exec_SELECTquery() on a non-object in typo3/sysext/core/Classes/Registry.php on line 86"AbstractCoreUpdate.php:63This resolves the database connection problem, but I'm not sure if this is the right place. -
Andreas Kienast uploaded patch set 2 09/05/18, 18:49
-
Markus Klein uploaded patch set 4 09/05/18, 18:49
-
Markus Klein uploaded patch set 5 09/05/18, 18:49
-
Markus Klein uploaded patch set 6 09/05/18, 18:49
-
Markus Klein updated the commit message in patch set 6 09/05/18, 18:49
-
Markus Klein updated the commit message in patch set 7 09/05/18, 18:49
-
Markus Klein commented on patch set 8 V +2 CR +2 09/05/18, 18:49
Since I refactored this back then, I know what I did wrong. ;-) -
Markus Klein merged patch set 9 09/05/18, 18:49
-
Christian Kuhn commented on patch set 3 CR -1 09/05/18, 18:49
I don't think changing typo3/sysext/extbase/Classes/Mvc/View/AbstractView.php is the correct approach to fix this issue, imho a bugfix should stay within ext:install? ... will review, but not not, give me some time. -
Christian Kuhn commented on patch set 3 09/05/18, 18:49
up. we need to fix this. will dig into this tomorrow evening. -
Christian Kuhn commented on patch set 6 09/05/18, 18:49
thx! will review tomorrow :) -
Christian Kuhn voted on patch set 7 V +1 CR +1 09/05/18, 18:49
-
Christian Kuhn voted on patch set 8 V +1 CR +1 09/05/18, 18:49
-
Philipp Gampe voted on patch set 8 CR +1 09/05/18, 18:49
-
Mr. Jenkins commented on patch set 3 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15096/ : SUCCESS -
Mr. Jenkins commented on patch set 4 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15300/ : SUCCESS -
Mr. Jenkins commented on patch set 5 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15302/ : SUCCESS -
Mr. Jenkins commented on patch set 6 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15303/ : SUCCESS -
Mr. Jenkins commented on patch set 7 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15304/ : SUCCESS -
Mr. Jenkins commented on patch set 8 09/05/18, 18:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15305/ : SUCCESS -
Andreas Kienast uploaded patch set 3 09/05/18, 18:49
-
Andreas Kienast commented on patch set 3 1 comment 09/05/18, 18:49