28419[BUGFIX] Cached class loader misses are not considered
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Alexander Opitz +1
-
Verified V +2
- Markus Klein +2
- Alexander Opitz +1
Files 2
Review log 51
Show 26 earlier messages
-
Thomas Maroschik updated the commit message in patch set 1 03/15/14, 12:31
-
Thomas Maroschik updated the commit message in patch set 2 03/15/14, 12:32
-
Thomas Maroschik wrote 03/15/14, 12:50
Topic set to "performance". -
Mr. Jenkins commented on patch set 1 CR -1 V -1 03/15/14, 13:43
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/15132/ : FAILURE -
Mr. Jenkins commented on patch set 2 03/15/14, 13:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15133/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/15/14, 14:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15134/ : SUCCESS -
Wouter Wolters voted on patch set 3 CR +1 03/15/14, 15:35
-
Steffen Ritter commented on patch set 3 CR +1 03/15/14, 17:00
reads fine, not sure how to test. -
Helmut Hummel commented on patch set 3 CR -1 03/16/14, 10:22
The check has to be done earlier, so that the class info is not rebuilt when the class has not been found before. -
Helmut Hummel commented on patch set 3 03/16/14, 10:25
Proposal: $this->getClassLoadingInformationFromCache($cacheEntryIdentifier); returns FALSE on cache miss and NULL or array on cache hit. Then not build class information if value is NULL -
Thomas Maroschik commented on patch set 3 03/16/14, 10:28
Would be OK from my perspective as explode also returns false if something is wrong with the cache entry. -
Thomas Maroschik uploaded patch set 4 03/16/14, 10:42
-
Thomas Maroschik uploaded patch set 5 03/16/14, 10:44
-
Mr. Jenkins commented on patch set 4 03/16/14, 11:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15175/ : SUCCESS -
Helmut Hummel commented on patch set 5 CR +1 03/16/14, 11:04
Can't do a full review on my phone, but as far as I can see, it looks good now. thanks! -
Mr. Jenkins commented on patch set 5 03/16/14, 11:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15176/ : SUCCESS -
Markus Klein commented on patch set 5 CR +1 03/16/14, 12:21
All lowercase false -> FALSEcaches -> crashes?ClassLoader.php:187FALSE|NULL -
Markus Klein uploaded patch set 6 03/18/14, 10:28
-
Markus Klein updated the commit message in patch set 6 03/18/14, 10:34
-
Markus Klein voted on patch set 7 CR +1 03/18/14, 10:34
-
Mr. Jenkins commented on patch set 6 03/18/14, 11:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15253/ : SUCCESS -
Mr. Jenkins commented on patch set 7 03/18/14, 11:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15254/ : SUCCESS -
Oliver Klee commented on patch set 7 CR -1 03/18/14, 11:45
ClassLoader.php:200null -> NULLClassLoader.php:366null -> FALSE -
Markus Klein uploaded patch set 8 03/18/14, 12:14
-
Markus Klein commented on patch set 8 CR +1 03/18/14, 12:14
NULL fixed -
Oliver Klee voted on patch set 8 CR +1 03/18/14, 12:21
-
Mr. Jenkins commented on patch set 8 03/18/14, 12:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15266/ : SUCCESS -
Thomas Maroschik voted on patch set 8 CR +1 03/18/14, 13:13
-
Wouter Wolters commented on patch set 8 CR -1 03/18/14, 19:01
ClassLoader.php:366FALSE -
Markus Klein commented on patch set 8 03/18/14, 19:23
ClassLoader.php:366ReplyDone -
Markus Klein uploaded patch set 9 03/18/14, 19:23
-
Markus Klein voted on patch set 9 CR +1 03/18/14, 19:24
-
Oliver Klee voted on patch set 9 CR +1 03/18/14, 19:24
-
Wouter Wolters voted on patch set 9 CR +1 03/18/14, 19:28
-
Mr. Jenkins commented on patch set 9 03/18/14, 19:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15285/ : SUCCESS -
Thomas Maroschik voted on patch set 9 CR +1 03/18/14, 21:18
-
Markus Klein commented on patch set 9 CR -1 03/20/14, 16:31
ClassLoader.php:231can return NULL tooClassLoader.php:241can be NULL too -
Ernesto Baschny commented on patch set 9 03/20/14, 16:40
Markus will further work on this, maybe we can get also the issues #57094 and #56993 solved with it. Thanks! -
Markus Klein uploaded patch set 10 03/20/14, 16:40
-
Mr. Jenkins commented on patch set 10 03/20/14, 16:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15370/ : SUCCESS -
Markus Klein voted on patch set 10 CR +1 03/20/14, 17:01
-
Markus Klein uploaded patch set 11 03/20/14, 17:07
-
Markus Klein commented on patch set 11 CR +1 03/20/14, 17:07
Just fixed one more phpdoc mistake -
Markus Klein voted on patch set 11 V +1 03/20/14, 17:09
-
Mr. Jenkins commented on patch set 11 03/20/14, 17:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15371/ : SUCCESS -
Alexander Opitz voted on patch set 11 V +1 CR +1 03/20/14, 17:21
-
Markus Klein voted on patch set 11 V +2 CR +2 03/20/14, 17:30
-
Markus Klein merged patch set 12 03/20/14, 17:30
-
Helmut Hummel commented on patch set 12 03/20/14, 18:24
-1 Post reviewClassLoader.php:213Returning FALSE here, does introduce the bug again which should have been fixed with this merge! -
Markus Klein commented on patch set 12 03/20/14, 19:03
ClassLoader.php:213ReplyActually the commit message says "cache misses". These are considered. This case is about cache hit, but missing class. https://review.typo3.org/28577 -
Markus Klein commented on patch set 12 03/20/14, 19:06
ClassLoader.php:213ReplyWell I understood the header wrong^^ "Cached class loader misses are not considered" means "Cached information about missing classes" ;-) So yes, should have been fixed here. will be fixed with the other patch.