Review main Abandoned

28463[BUGFIX] usage of reserved word as property in JS

Christian Zenker CR 0 V 0 Easy +1 −1 updated 05/14/14, 08:55

Commit message

"delete" is a reserved word in Javascript and causes a
parsing error in Internet Explorer up to 8 when used
as property name.

As solution the brace notation (["delete"]) is used
instead of the dot notation(.delete)

This is a regression from #56356.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 03/17/14, 12:46

  2. Helmut Hummel commented on patch set 1 CR +1 03/17/14, 14:08

    would be fine with merging, but I will restructure the notation and namespace of the Ajax urls anyway somewhen this week to make them consistent....
  3. Christoph Lehmann commented on patch set 1 V -1 CR -1 03/18/14, 09:35

    I applied the patch, but it ended in another error christian zenker reported
  4. Helmut Hummel commented on patch set 1 CR -2 03/26/14, 22:07

    This is not required any more
  5. Helmut Hummel commented on patch set 1 03/26/14, 22:12

    Ajax URLs are now accessible via TYPO3.settings.ajaxUrls['ajaxId'], so there is no issue with reserved properties any more
  6. Christian Zenker abandoned the change 05/14/14, 08:55

    problem no longer exists according to Helmut