28464[BUGFIX] Hide "new page buttons" for users who can't create new pages
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Stefan Neufeind +1
- Georg Ringer +1
- Wouter Wolters +1
-
Verified V +2
- Nicole Hummel +2
- Stefan Neufeind +1
- Georg Ringer +1
Issues 1
Files 1
Review log 26
Show 1 earlier messages
-
Mr. Jenkins commented on patch set 1 03/17/14, 13:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15201/ : SUCCESS
-
Stefan Neufeind commented on patch set 1 CR +1 03/17/14, 15:17
Changes itself look okay. Check is done the same way in other places.We usually don't have that sort of information in the commit-msg, just in gerrit. commit-msg should contain an info what is changed (imho even if it doesn't have that much background-information). -
Alexander Stehlik commented on patch set 1 03/17/14, 16:33
Will this check also consider if the user has the right to create pages within the current page? As far as I can see BackendUserAuthentication->check() only cares about editable tables but not about the access right set with the access module.NewRecordController.php:391I think the performance would be better when the checks are switched. -
Georg Ringer uploaded patch set 2 03/18/14, 06:19
-
Mr. Jenkins commented on patch set 2 03/18/14, 06:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15239/ : SUCCESS -
Stefan Froemken commented on patch set 2 V +1 CR +1 03/18/14, 08:02
It works, but what about the createNew-link in pagetree and the createNew-link in contextmenu? -
Alexander Stehlik commented on patch set 2 CR -1 03/18/14, 08:37
Is there a reason why you do not use the newPagesInto class property for this check? Maybe it would even be better to place this check in the showNewRecLink() method. -
Alexander Stehlik commented on patch set 2 CR +1 03/18/14, 09:13
I think I get it now, since the link takes you to the wizard this check would not make much sense. -
Alexander Stehlik uploaded patch set 3 03/18/14, 09:42
-
Alexander Stehlik voted on patch set 3 V +1 CR +1 03/18/14, 09:43
-
Mr. Jenkins commented on patch set 3 03/18/14, 10:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15244/ : SUCCESS -
Stefan Neufeind voted on patch set 3 CR +1 03/18/14, 10:02
-
Stefan Froemken commented on patch set 3 03/18/14, 10:28
NewRecordController.php:383And why you don't use your new method here?NewRecordController.php:388and here? -
Alexander Stehlik commented on patch set 3 03/18/14, 10:32
Good point, when I touch these lines anyway... new patch is on the way. -
Alexander Stehlik uploaded patch set 4 03/18/14, 11:07
-
Mr. Jenkins commented on patch set 4 03/18/14, 11:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15257/ : SUCCESS -
Georg Ringer uploaded patch set 5 03/19/14, 05:14
-
Georg Ringer uploaded patch set 6 03/19/14, 05:16
-
Georg Ringer commented on patch set 6 03/19/14, 05:17
sry for wrong push, reuploaded patchset 4 -
Georg Ringer voted on patch set 6 V +1 CR +1 03/19/14, 05:17
-
Mr. Jenkins commented on patch set 5 03/19/14, 05:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15309/ : SUCCESS -
Mr. Jenkins commented on patch set 6 03/19/14, 05:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15310/ : SUCCESS -
Wouter Wolters voted on patch set 6 CR +1 03/19/14, 19:21
-
Stefan Neufeind voted on patch set 6 V +1 CR +1 03/21/14, 22:37
-
Nicole Hummel voted on patch set 6 V +2 CR +2 03/21/14, 22:52
-
Nicole Hummel merged patch set 7 03/21/14, 22:52