Review main Merged

28464[BUGFIX] Hide "new page buttons" for users who can't create new pages

Georg Ringer CR +2 V +2 Easy +17 −4 updated 03/21/14, 22:52

Commit message

There are 2 icons in the New Element wizard which should not belong there
and get the user into a blank page if the user got no access to create
page records.

- in the toolbar: icon to create a new page
- in the wizard: icon to create new page

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Nicole Hummel +2
    • Stefan Neufeind +1
    • Georg Ringer +1

Issues 1

Files 1

Review log 26

Show 1 earlier messages
  1. Mr. Jenkins commented on patch set 1 03/17/14, 13:11

  1. Stefan Neufeind commented on patch set 1 CR +1 03/17/14, 15:17

    Changes itself look okay. Check is done the same way in other places.
    We usually don't have that sort of information in the commit-msg, just in gerrit. commit-msg should contain an info what is changed (imho even if it doesn't have that much background-information).
  2. Alexander Stehlik commented on patch set 1 03/17/14, 16:33

    Will this check also consider if the user has the right to create pages within the current page? As far as I can see BackendUserAuthentication->check() only cares about editable tables but not about the access right set with the access module.

    NewRecordController.php:391

    I think the performance would be better when the checks are switched.
  3. Georg Ringer uploaded patch set 2 03/18/14, 06:19

  4. Mr. Jenkins commented on patch set 2 03/18/14, 06:31

  5. Stefan Froemken commented on patch set 2 V +1 CR +1 03/18/14, 08:02

    It works, but what about the createNew-link in pagetree and the createNew-link in contextmenu?
  6. Alexander Stehlik commented on patch set 2 CR -1 03/18/14, 08:37

    Is there a reason why you do not use the newPagesInto class property for this check? Maybe it would even be better to place this check in the showNewRecLink() method.
  7. Alexander Stehlik commented on patch set 2 CR +1 03/18/14, 09:13

    I think I get it now, since the link takes you to the wizard this check would not make much sense.
  8. Alexander Stehlik uploaded patch set 3 03/18/14, 09:42

  9. Alexander Stehlik voted on patch set 3 V +1 CR +1 03/18/14, 09:43

  10. Mr. Jenkins commented on patch set 3 03/18/14, 10:00

  11. Stefan Neufeind voted on patch set 3 CR +1 03/18/14, 10:02

  12. Stefan Froemken commented on patch set 3 03/18/14, 10:28

    NewRecordController.php:383

    And why you don't use your new method here?

    NewRecordController.php:388

    and here?
  13. Alexander Stehlik commented on patch set 3 03/18/14, 10:32

    Good point, when I touch these lines anyway... new patch is on the way.
  14. Alexander Stehlik uploaded patch set 4 03/18/14, 11:07

  15. Mr. Jenkins commented on patch set 4 03/18/14, 11:41

  16. Georg Ringer uploaded patch set 5 03/19/14, 05:14

  17. Georg Ringer uploaded patch set 6 03/19/14, 05:16

  18. Georg Ringer commented on patch set 6 03/19/14, 05:17

    sry for wrong push, reuploaded patchset 4
  19. Georg Ringer voted on patch set 6 V +1 CR +1 03/19/14, 05:17

  20. Mr. Jenkins commented on patch set 5 03/19/14, 05:29

  21. Mr. Jenkins commented on patch set 6 03/19/14, 05:43

  22. Wouter Wolters voted on patch set 6 CR +1 03/19/14, 19:21

  23. Stefan Neufeind voted on patch set 6 V +1 CR +1 03/21/14, 22:37

  24. Nicole Hummel voted on patch set 6 V +2 CR +2 03/21/14, 22:52

  25. Nicole Hummel merged patch set 7 03/21/14, 22:52