Review main Merged

28481[BUGFIX] Documentation does not initialize signal slot dispatcher

Philipp Gampe CR +2 V +2 Easy +2 −1 updated 03/17/14, 22:04

Commit message

The documentation module does not initialize the signal slot dispatcher
in its ext_localconf.php, but rather reuses the already set variable
from another core extension.

Create the object explicitly before using it.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 5

  1. Philipp Gampe updated the commit message in patch set 1 03/17/14, 21:38

  2. Stefan Neufeind commented on patch set 2 V +2 CR +2 03/17/14, 21:48

    easy. the only correct way to do it. Documentation-module is new in 6.2, so no previous releases affected.
  3. Stefan Neufeind merged patch set 3 03/17/14, 21:48

  4. Mr. Jenkins commented on patch set 1 03/17/14, 22:01

  5. Mr. Jenkins commented on patch set 2 03/17/14, 22:04